-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: init GitHub Actions CI for Keto #823
Conversation
146d870
to
d87a387
Compare
P.S. the first autogen commit was from CircleCI. |
- run: | | ||
docker create --name cockroach -p 26257:26257 \ | ||
cockroachdb/cockroach:v20.2.5 start-single-node --insecure | ||
docker start cockroach | ||
name: Start CockroachDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not a service like postgres and mysql? Just asking out of curiosity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub, it appears, like to release half-baked features — service containers don't support overriding the default entrypoint command, or even passing args to them. And with Cockroach, we'd like to run it with the start-single-node --insecure
args, and this isn't possible with service containers. So back to the old fashioned way of spinning up a container in the background, by hand. :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha ok, makes sense.
@icyphox isn't this missing - similar to Ory Hydra - the post-release step with the docs building stuff? |
@aeneasr that's already baked into the ory/ci/releaser action. No further setup required. |
😎 |
This PR introduces a GitHub Actions workflow for CI. There are no new secrets required for this workflow. As always, remember to create an environment
production
from the repo settings.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.