Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: init GitHub Actions CI for Keto #823

Merged
merged 5 commits into from
Feb 4, 2022
Merged

ci: init GitHub Actions CI for Keto #823

merged 5 commits into from
Feb 4, 2022

Conversation

icyphox
Copy link
Contributor

@icyphox icyphox commented Feb 3, 2022

This PR introduces a GitHub Actions workflow for CI. There are no new secrets required for this workflow. As always, remember to create an environment production from the repo settings.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2022

CLA assistant check
All committers have signed the CLA.

@icyphox icyphox marked this pull request as ready for review February 3, 2022 09:05
@icyphox icyphox requested a review from zepatrik as a code owner February 3, 2022 09:05
@icyphox
Copy link
Contributor Author

icyphox commented Feb 3, 2022

P.S. the first autogen commit was from CircleCI.

Comment on lines +63 to +67
- run: |
docker create --name cockroach -p 26257:26257 \
cockroachdb/cockroach:v20.2.5 start-single-node --insecure
docker start cockroach
name: Start CockroachDB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not a service like postgres and mysql? Just asking out of curiosity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub, it appears, like to release half-baked features — service containers don't support overriding the default entrypoint command, or even passing args to them. And with Cockroach, we'd like to run it with the start-single-node --insecure args, and this isn't possible with service containers. So back to the old fashioned way of spinning up a container in the background, by hand. :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha ok, makes sense.

@zepatrik zepatrik merged commit 1effd79 into master Feb 4, 2022
@zepatrik zepatrik deleted the ci/github-actions branch February 4, 2022 15:59
@aeneasr
Copy link
Member

aeneasr commented Feb 4, 2022

@icyphox isn't this missing - similar to Ory Hydra - the post-release step with the docs building stuff?

@icyphox
Copy link
Contributor Author

icyphox commented Feb 4, 2022

@aeneasr that's already baked into the ory/ci/releaser action. No further setup required.

@aeneasr
Copy link
Member

aeneasr commented Feb 4, 2022

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants