Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve emitting of events #1314

Merged
merged 4 commits into from
Apr 19, 2023
Merged

feat: improve emitting of events #1314

merged 4 commits into from
Apr 19, 2023

Conversation

CaptainStandby
Copy link
Contributor

@CaptainStandby CaptainStandby commented Apr 13, 2023 •
edited
Loading

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

hperl
hperl requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good already with some minor remarks :)

internal/x/events/events.go Outdated Show resolved Hide resolved
internal/driver/daemon.go Show resolved Hide resolved
alnr
alnr requested changes Apr 14, 2023
View reviewed changes
x/events/events.go Outdated Show resolved Hide resolved
@CaptainStandby CaptainStandby self-assigned this Apr 17, 2023
@CaptainStandby CaptainStandby requested review from hperl and alnr April 19, 2023 13:35
@hperl hperl added this pull request to the merge queue Apr 19, 2023
Merged via the queue into master with commit 5028c75 Apr 19, 2023
@hperl hperl deleted the hf/metrics_1 branch April 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alnr alnr alnr approved these changes

@aeneasr aeneasr aeneasr approved these changes

@hperl hperl hperl approved these changes

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

Assignees

@CaptainStandby CaptainStandby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaptainStandby @hperl @aeneasr @alnr