Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --skip-logout-consent flag to CLI #3709

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 31, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from hperl as a code owner January 31, 2024 11:32
hperl
hperl previously approved these changes Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fa2889) 76.06% compared to head (916019c) 76.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3709   +/-   ##
=======================================
  Coverage   76.06%   76.06%           
=======================================
  Files         134      134           
  Lines       10140    10142    +2     
=======================================
+ Hits         7713     7715    +2     
  Misses       1910     1910           
  Partials      517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit f502d6e into master Jan 31, 2024
31 checks passed
@aeneasr aeneasr deleted the skip-logout-consent-cli branch January 31, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants