chore: Update x/sys to support go 1.17#2687
Merged
aeneasr merged 1 commit intoory:masterfrom Aug 23, 2021
gordonbondon:upgrade-sys-go117
Merged
chore: Update x/sys to support go 1.17#2687aeneasr merged 1 commit intoory:masterfrom gordonbondon:upgrade-sys-go117
aeneasr merged 1 commit intoory:masterfrom
gordonbondon:upgrade-sys-go117
Conversation
Contributor
Author
|
I can't replicate test failure locally, so seems unrelated: |
Member
|
Yup, it's a flaky test! I'll re-run the CI now |
Codecov Report
@@ Coverage Diff @@
## master #2687 +/- ##
==========================================
+ Coverage 52.69% 52.71% +0.01%
==========================================
Files 234 234
Lines 14040 14040
==========================================
+ Hits 7399 7401 +2
+ Misses 6013 6012 -1
+ Partials 628 627 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating x/sys so that this project supports go 1.17.
More context: Homebrew/homebrew-core#83413
Without this fix running a binary can cause a panic, see upstream go issue: golang/go#45702
Related issue(s)
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.