-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch from lib/pq to jackc/pgx #1736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not merge this one until ory/x#118 is merged so that I could remove the |
57b099d
to
91c53ce
Compare
21b34d0
to
7fcd905
Compare
Done: "if pgx then dialect = postgres", change was made in |
7fcd905
to
59e1ded
Compare
@aeneasr PTAL. |
aeneasr
approved these changes
Feb 23, 2020
Thank you! Released as a new version |
aeneasr
added a commit
that referenced
this pull request
Feb 23, 2020
Do not forget to remove the replace in the go.mod:
replace github.com/ory/x => github.com/glerchundi/x
v0.0.97-0.20200221090043-7f3ebe7b46ec
…On Sun, 23 Feb 2020 at 13:40, hackerman ***@***.***> wrote:
Thank you! Released as a new version
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1736?email_source=notifications&email_token=AARA7FTA7GT4I432OUIR6OTREJVFJA5CNFSM4KYTPAOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMV2YKI#issuecomment-590064681>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARA7FQOIS46VB7BYDWM6YLREJVFJANCNFSM4KYTPAOA>
.
|
eli-zh
pushed a commit
to eli-zh/hydra
that referenced
this pull request
Mar 22, 2020
eli-zh
pushed a commit
to eli-zh/hydra
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1599