Skip to content

Commit

Permalink
oauth2: Resolves various issues related to audience claims
Browse files Browse the repository at this point in the history
This patch resolves issues related to the ID and Access Token audience
claim:

* oauth2: Allow multiple audience claims on ID token - closes #790
* oauth2: Reintroduce audience claim - closes #687
  • Loading branch information
arekkas committed May 29, 2018
1 parent 408e36e commit e08f82c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion oauth2/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,8 @@ func (h *Handler) AuthHandler(w http.ResponseWriter, r *http.Request, _ httprout
response, err := h.OAuth2.NewAuthorizeResponse(ctx, authorizeRequest, &Session{
DefaultSession: &openid.DefaultSession{
Claims: &jwt.IDTokenClaims{
Audience: authorizeRequest.GetClient().GetID(),
// We do not need to pass the audience because it's included directly by ORY Fosite
//Audience: []string{authorizeRequest.GetClient().GetID()},
Subject: session.ConsentRequest.Subject,
Issuer: h.IssuerURL,
IssuedAt: time.Now().UTC(),
Expand All @@ -475,6 +476,8 @@ func (h *Handler) AuthHandler(w http.ResponseWriter, r *http.Request, _ httprout
Subject: session.ConsentRequest.Subject,
},
Extra: session.Session.AccessToken,
// Here, we do not include the client because it's typically not the audience.
Audience: []string{},
})
if err != nil {
pkg.LogError(err, h.L)
Expand Down

0 comments on commit e08f82c

Please sign in to comment.