Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added rbac guide for keto #749

Merged
merged 4 commits into from
May 12, 2022
Merged

fix: added rbac guide for keto #749

merged 4 commits into from
May 12, 2022

Conversation

gen1us2k
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

docs/keto/guides/rbac.mdx Outdated Show resolved Hide resolved
docs/keto/guides/rbac.mdx Outdated Show resolved Hide resolved
docs/keto/guides/rbac.mdx Outdated Show resolved Hide resolved
docs/keto/guides/rbac.mdx Outdated Show resolved Hide resolved
@gen1us2k
Copy link
Contributor Author

@hperl @zepatrik Hello. I fixed everything and it looks fine now. The guide uses keto cli instead of curl examples. WDYT?

@hperl
Copy link
Collaborator

hperl commented May 10, 2022

@hperl @zepatrik Hello. I fixed everything and it looks fine now. The guide uses keto cli instead of curl examples. WDYT?

Thanks, LGTM!

@hperl
Copy link
Collaborator

hperl commented May 11, 2022

@zepatrik LGTM, but I can't approve. Can you?

@aeneasr aeneasr merged commit 5d6200e into master May 12, 2022
@aeneasr aeneasr deleted the rbac_new branch May 12, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants