[FIX] Functionality Issues #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue:
N/A
Description of Issue:
Solution
This change will set the options back to the class during the setup function.
Long breaks option is used in the if statement to ensure we are long breaking at the correct interval.
Removing the BufLeave event listener on the menu removes the case where we stop the timer that should be running. This allows the timers to function as they should.
Features:
This also includes rewritten code from orumin/pomodoro.nvim. Having the class typed was one motivation but the other was the ability to have the symbols configurable.
Notes:
This changeset incorporates:
wthollingsworth#10 for time formatting