Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components to tag prop types #548

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

jonathanjameswatson
Copy link
Contributor

@jonathanjameswatson jonathanjameswatson commented Jun 18, 2023

Fixes warnings in #502

Proposed Changes

  • Adds Component to the types of all tag props, allowing actual components to be given as tag props, in addition to component names.

@netlify
Copy link

netlify bot commented Jun 18, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit af3ab95
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/648f16b80980660008d5d205
😎 Deploy Preview https://deploy-preview-548--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1dc1f2d) 62.87% compared to head (af3ab95) 62.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #548   +/-   ##
========================================
  Coverage    62.87%   62.87%           
========================================
  Files           79       79           
  Lines         5535     5535           
  Branches      1536     1536           
========================================
  Hits          3480     3480           
  Misses        1945     1945           
  Partials       110      110           
Flag Coverage Δ
oruga 65.99% <ø> (ø)
oruga-next 48.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-next/src/components/autocomplete/Autocomplete.vue 52.33% <ø> (ø)
...ckages/oruga-next/src/components/button/Button.vue 70.27% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtommy jtommy merged commit 7c62f2b into oruga-ui:develop Jun 18, 2023
@jtommy
Copy link
Member

jtommy commented Jun 18, 2023

@jonathanjameswatson thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants