MdtmMan worked with ZfpMan for automatic compression and decompression - #87
Merged
Conversation
chuckatkins
suggested changes
Apr 24, 2017
chuckatkins
left a comment
chuckatkins
left a comment
Contributor
There was a problem hiding this comment.
Good additions, only a few minor "cosmetic" changes requested.
| bool DataManBase::auto_transform(std::vector<char> &a_data, json &a_jmsg) | ||
| { | ||
| if (p_jmsg["compression_method"] != nullptr) | ||
| if (a_jmsg["compression_method"].is_string() and |
Contributor
There was a problem hiding this comment.
I'd like to avoid using the alternative "ascii" logic operators like and and not and stick with the symbolic operators && and !. It's really just syntactical sugar that isn't bringing any additional functionality at the expense of inconsistent representation of logical expressions. Also it isn't used anywhere else in the code base right now.
| auto method = a_jmsg["compression_method"].get<std::string>(); | ||
| auto man = get_man(method); | ||
| if (man == nullptr) | ||
| if (not man) |
| @@ -24,7 +24,7 @@ class ZfpMan : public CompressMan | |||
| virtual void flush(); | |||
| void *compress(void *p_data, json &p_jmsg); | |||
Contributor
There was a problem hiding this comment.
compress and decompress should have comments that document the memory they return needs to be freed by the caller else it will leak.
| // This part will go away, this is just to monitor variables per rank | ||
|
|
||
| if (variable.m_GlobalDimensions.empty()) | ||
| variable.m_GlobalDimensions = variable.m_LocalDimensions; |
chuckatkins
approved these changes
Apr 24, 2017
vicentebolea
pushed a commit
to eisenhauer/ADIOS2
that referenced
this pull request
Jan 7, 2025
Code extracted from:
https://github.com/GTkorvo/EVPath.git
at commit 5663b5a6a84dd35bc65a9ce1789697b0f7b95b41 (master).
Upstream Shortlog
-----------------
Greg Eisenhauer (21):
96ee8ed4 Changes to support windows static builds
330d16ee kill warnings
436c066f kill warnings
2be8c201 kill warnings
e2891021 kill warnings
5fe51032 remove spurious printf
fbfc7b54 Make NO_RDMA more robust
046d3d6b Fixes for FreeBSD
5c2a258a Mostly working on Windows
2b0e5669 macros for non-windows
629310aa Windows support + untabify
8c9ed404 Add CManager ID to contact info and use it for conn_eq
b3097f75 Windows Warnings
eccd8334 bump version
15dcbcde Add another mechanism for getting the hostname
62f7980c Mingw changes
a63862a2 update version
236c8e16 More tweaks for mingw
86ce11b4 Build without perl if not found (ornladios#87)
ee6a7af7 Add missing pregen
b4b3b548 Update CMake for newer verions
eisenhauer
pushed a commit
to eisenhauer/ADIOS2
that referenced
this pull request
Apr 17, 2026
Code extracted from:
https://github.com/GTkorvo/dill.git
at commit 9d32c1df536547e8b782a899a3d16697f978f55c (master).
Upstream Shortlog
-----------------
Greg Eisenhauer (4):
ce161228 Add global register pre-assignment for virtual mode loops (ornladios#84)
1929b841 ARM64 built-in disassembler for dill_dump (ornladios#85)
9afe8637 Restore JIT execute mode in finalize_package and free_stream (ornladios#86)
9d32c1df Fix ARM64 Linux support (ornladios#87)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Apr 17, 2026
Code extracted from:
https://github.com/GTkorvo/dill.git
at commit 0dd0aabd5302de3f8e69f24f3d3995d9701f5ca2 (master).
Upstream Shortlog
-----------------
Greg Eisenhauer (4):
1929b841 ARM64 built-in disassembler for dill_dump (ornladios#85)
9afe8637 Restore JIT execute mode in finalize_package and free_stream (ornladios#86)
9d32c1df Fix ARM64 Linux support (ornladios#87)
0dd0aabd Add ARM64 Linux CI job (ornladios#88)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Apr 17, 2026
Code extracted from:
https://github.com/GTkorvo/dill.git
at commit 0dd0aabd5302de3f8e69f24f3d3995d9701f5ca2 (master).
Upstream Shortlog
-----------------
Greg Eisenhauer (4):
1929b841 ARM64 built-in disassembler for dill_dump (ornladios#85)
9afe8637 Restore JIT execute mode in finalize_package and free_stream (ornladios#86)
9d32c1df Fix ARM64 Linux support (ornladios#87)
0dd0aabd Add ARM64 Linux CI job (ornladios#88)
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Apr 17, 2026
Code extracted from:
https://github.com/GTkorvo/dill.git
at commit 0dd0aabd5302de3f8e69f24f3d3995d9701f5ca2 (master).
Upstream Shortlog
-----------------
Greg Eisenhauer (4):
1929b841 ARM64 built-in disassembler for dill_dump (ornladios#85)
9afe8637 Restore JIT execute mode in finalize_package and free_stream (ornladios#86)
9d32c1df Fix ARM64 Linux support (ornladios#87)
0dd0aabd Add ARM64 Linux CI job (ornladios#88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.