Make MGARD lossless type configurable - #5015
Merged
eisenhauer merged 2 commits intoApr 22, 2026
Merged
Conversation
This is enabled by a new "lossless_type" operator parameter that can strictly take the values "huffman" or "huffman_ztsd". The default remains Huffman_Zstd for backwards compatibility. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Member
|
I was going to call out the lack of update to the mgard page in docs, but it appears that we don't have one! That would seem to be a problem, but it is not your problem to fix. I'd say we should also allow the other values of lossless_type to be specified, but I'm happy to leave that until this gets documented... |
eisenhauer
approved these changes
Apr 22, 2026
Contributor
Author
|
@eisenhauer thanks for the prompt review and merge. I didn't stop to think about the other values in the |
rtobar
added a commit
to ICRAR/docker-casacore
that referenced
this pull request
Apr 22, 2026
This is because ornladios/ADIOS2#5015 has been accepted and merged. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
eisenhauer
added a commit
that referenced
this pull request
Apr 22, 2026
Make MGARD lossless type configurable (cherry picked from commit 1fcd3b0)
eisenhauer
added a commit
that referenced
this pull request
Apr 22, 2026
…-5015 Backport #5015 to release_212
vicentebolea
added a commit
that referenced
this pull request
Apr 29, 2026
* origin/release_212: update bpcmp test output Fix printing double values in bpls min/max and the Min and Max strings of the io.AvailableVariables() result map/dictionary. Note: %g in printf and cout << doublevar in C++ renders 6 significant digits by default and a value like 130255.32345 is printed as 130255, looking like an integer. Now we print 1.302553e+05. In case of bpls, min/max for small values (-10000, 10000) are still printed with %g, but outside that they are printed with %e. Bump version to v2.12.1 Merge pull request #5022 from eisenhauer/cxi-slingshot-error-msg Merge pull request #5015 from rtobar/mgard-lossless-type-parameter Merge pull request #5010 from eisenhauer/sst-nfs-dcache-fix Merge pull request #5008 from ordinary-slim/patch-1 vectorize min/max with SIMD for float, double, and integer types (#4985) dill 2026-04-17 (9d32c1df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is enabled by a new
lossless_typeoperator parameter that can strictly take the valueshuffmanorhuffman_ztsd. The default remains Huffman_Zstd for backwards compatibility.