Adding SYCL support to the Kokkos backend #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
changed the title
|
This is ready for review @masterleinad let me know if you have any comments on the SYCL specific functions |
anagainaru
changed the title
|
@anagainaru this looks good, but in principle I would skip it for the patch release since this is not a bugfix. Is there a reason of why would you need this in the next patch release? |
|
@vicentebolea you are right, I will rebase it over master |
That makes sense to wait for the rebase, the CI should pass in less then 1h. |
|
@anagainaru #3623 was merged to master |
|
Rebased and ready to be reviewed one last time |
masterleinad
approved these changes
May 18, 2023
vicentebolea
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the SYCL backend in ADIOS2 (tested on ALCF Polaris with oneapi and clang++)
This was also tested with the new build system that Vicente is pushing in #3623
One change that affects the other backends is that
long doublewill no longer be supported for metadata computation (min/max) since it is not supported by several configurations I tried running on.