Make MaxPollCount Configurable. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4lm
requested changes
Jul 30, 2024
| @@ -1,6 +1,7 @@ | |||
| dependencies { | |||
|
|
|||
| implementation "redis.clients:jedis:${versions.revJedis}" | |||
| implementation 'org.springframework.boot:spring-boot-starter' | |||
There was a problem hiding this comment.
We would like to avoid bringing this in here.
There was a problem hiding this comment.
May I know why?
This dependency is required to initialise QueueMonitorProperties
| @@ -42,6 +42,14 @@ public abstract class QueueMonitor { | |||
|
|
|||
| private int maxPollCount = 100; | |||
|
|
|||
| public void setMaxPollCount(int maxPollCount) { | |||
| this.maxPollCount = maxPollCount; | |||
There was a problem hiding this comment.
The ArrayBlockingQueue is being initalized in the constructor with maxPollCount. If you wish to make use of this, please propagate it.
There was a problem hiding this comment.
Thanks for catching that. Done.
|
@c4lm - Can you please review this PR again? |
|
@manan164 @v1r3n @LuisLainez @c4lm - Can you please review this PR? |
manan164
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are facing issue with having the MaxPollCount hard coded to 100. That has reduced the performance of our system drastically.
This change is to make it configurable.