Remove constants module #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation modules. All types are now private and some constants are no longer public.
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage ? 96.18%
=========================================
Files ? 45
Lines ? 6190
Branches ? 0
=========================================
Hits ? 5954
Misses ? 236
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 96.17% 96.23% +0.06%
==========================================
Files 45 45
Lines 6190 6190
==========================================
+ Hits 5953 5957 +4
+ Misses 237 233 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
hazardous::constantsmodule. All public types therein have now been made private and only a selected number of constants are still public. They have been moved to the accompanying implementations module.The motivation for this is 1) Having all constants in one module, makes it tiresome to look up when you only want to see the ones relevant to the current interface you're working with. 2) The types and constants are represented through each newtype in every module, and the user shouldn't have to interact with them.