-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental implementation of CTX #324
Conversation
Looks good to me at a glance. One thing to consider would be adding an example of what problem this solves compared to non-committing AEAD. I'm not sure if that's helpful or not for theoretical consumers of the library. If we wanted to add an example, I thought the partitioning oracle attack was relatively straightforward. If we ever want to change over the high-level API to a committing AEAD, I don't think that kind of note would be helpful in the high-level docs since users aren't expected to really understand cryptography. But in the hazardous API, maybe it's good for people scrolling through the different options to have an understanding of the kinds of attacks this can prevent. |
If you mean add it in description and provide the link, then yes, completely agree! Though if you were thinking of an actual code example, I don't know if this would be too big/complex to have as an example.
Indeed. We should add this, but still mention in high-level that it is fully-committing (I mean, just they keyword, users can ignore it). Though, if somebody searches |
@vlmutolo was this the kind of documentation addition you were thinking of? |
see #317
experimental
hazardous::cae
TODO: