Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_empty() to newtypes #206

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Add is_empty() to newtypes #206

merged 3 commits into from
Jun 10, 2021

Conversation

brycx
Copy link
Member

@brycx brycx commented Jun 10, 2021

closes #205

@brycx brycx added the usability Issues or improvements related to UX label Jun 10, 2021
@brycx brycx requested a review from vlmutolo June 10, 2021 14:32
vlmutolo
vlmutolo reviewed Jun 10, 2021
View reviewed changes
vlmutolo
vlmutolo approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@vlmutolo vlmutolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the doc line. It's short and clear. I left one small change to consider, but otherwise I think it's good.

@brycx brycx merged commit d907024 into master Jun 10, 2021
@brycx brycx deleted the add-is-empty branch June 10, 2021 14:59
@brycx brycx added this to the v0.16.1 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlmutolo vlmutolo vlmutolo approved these changes

Assignees
No one assigned
Labels
usability Issues or improvements related to UX
Projects
None yet
Milestone
v0.16.1
Development

Successfully merging this pull request may close these issues.

Add is_empty() to public API of all newtypes that have implemented len()
2 participants
@brycx @vlmutolo