Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derives the style property from style object if not set by stylewindow #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnyblasta
Copy link
Contributor

Fixes #20
Some heinous if syntax to back reverse the OpenLayers Style object to the style property used in sharemap function.
Perhaps there are a better way to solve this?

@johnnyblasta johnnyblasta requested a review from jokd August 18, 2021 06:48
@jokd
Copy link
Contributor

jokd commented Sep 14, 2021

LGTM

@jokd
Copy link
Contributor

jokd commented Sep 14, 2021

One question though, would it be possible to instead do this when using the share map function? Assuring that the stored styling is correct that is.
Otherwise this works but a bit confusing if for instance we add another point symbol.

@johnnyblasta
Copy link
Contributor Author

One question though, would it be possible to instead do this when using the share map function? Assuring that the stored styling is correct that is.
Otherwise this works but a bit confusing if for instance we add another point symbol.

Perhaps the style should always have been set even though it was the default one. Then this way of deduce the style wouldn't be necessary.

@jokd
Copy link
Contributor

jokd commented Sep 14, 2021

If possible that woudl be the best. It would also be good to strip out the unnecessary parts of a features properties. Eg, a polygon still has a text property.

@johnnyblasta
Copy link
Contributor Author

If possible that woudl be the best. It would also be good to strip out the unnecessary parts of a features properties. Eg, a polygon still has a text property.

Yes, unnecessary parts bloats the data and makes it larger then it has to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawn object not always correctly shown with share map
2 participants