Sync to v0.1.2-nightly.20261021.3457 conflicts

.gitattributes

@@ -3,6 +3,7 @@
 # Batch files need CRLF for cmd.exe to parse them reliably.
 *.cmd text eol=crlf
 *.bat text eol=crlf
-# GitHub's GraphQL schema and the operations graphqlgen writes from it.
+# GitHub's and Expo's GraphQL schemas and the operations graphqlgen writes from them.
 packages/source-control-github/schema/** linguist-generated
+apps/server/schema/** linguist-generated
 **/*.graphql.ts linguist-generated

.github/scripts/check-nightly-release.test.cjs

@@ -61,12 +61,6 @@ for (const releaseChannel of ["stable", "nightly"]) {
     );
     assert.equal(calls.length, 0);
   });
-
-  test(`allows a manual ${releaseChannel} release from main`, async () => {
-    const { options, calls } = releaseSourceFixture();
-    await assertReleaseSource({ ...options, releaseChannel });
-    assert.equal(calls[0].basehead, "candidate...main");
-  });
 }
 
 for (const comparisonStatus of ["behind", "diverged"]) {
@@ -79,13 +73,6 @@ for (const comparisonStatus of ["behind", "diverged"]) {
   });
 }
 
-test("accepts a release commit already contained in main", async () => {
-  for (const comparisonStatus of ["ahead", "identical"]) {
-    const { options } = releaseSourceFixture({ comparisonStatus, eventName: "push" });
-    await assertCommitOnDefaultBranch({ ...options, sha: "release-commit" });
-  }
-});
-
 function fixture({ releases = [nightly(7)], comparisonStatus = "ahead" } = {}) {
   const calls = [];
   return {
@@ -119,26 +106,6 @@ test("releases the first nightly when no nightly is published", async () => {
   assert.equal(await shouldReleaseNightly(options), true);
 });
 
-test("waits six hours after publication, including manual nightlies", async () => {
-  for (const age of [0, 3, 6 - 1 / 3600]) {
-    const { options, calls } = fixture({ releases: [nightly(age)] });
-    assert.equal(await shouldReleaseNightly(options), false);
-    assert.equal(calls.length, 0);
-  }
-});
-
-test("releases new commits at six hours and after an idle period", async () => {
-  for (const age of [6, 7, 24]) {
-    const { options } = fixture({ releases: [nightly(age)] });
-    assert.equal(await shouldReleaseNightly(options), true);
-  }
-});
-
-test("skips unchanged commits after the gap", async () => {
-  const { options } = fixture({ comparisonStatus: "identical" });
-  assert.equal(await shouldReleaseNightly(options), false);
-});
-
 test("uses publication time, not release order or the tagged commit date", async () => {
   const { options } = fixture({
     releases: [nightly(10), nightly(1), nightly(20, { tag_name: "nightly-v0.9.0" })],
@@ -153,13 +120,6 @@ test("ignores stable releases and drafts when checking the gap", async () => {
   assert.equal(await shouldReleaseNightly(options), true);
 });
 
-test("compares against the published tag, including legacy nightly tags", async () => {
-  const tag = "nightly-v0.9.0";
-  const { options, calls } = fixture({ releases: [nightly(7, { tag_name: tag })] });
-  assert.equal(await shouldReleaseNightly(options), true);
-  assert.equal(calls[0].basehead, `${tag}...new`);
-});
-
 test("fails instead of releasing when GitHub cannot supply release state", async () => {
   const { options } = fixture();
   options.github.paginate = async () => {
@@ -211,8 +171,3 @@ test("stable releases derive the version from legacy nightly tags", async () =>
   });
   assert.equal((await resolveLatestNightlyCommit(options)).version, "0.9.0");
 });
-
-test("stable releases fail without a published nightly", async () => {
-  const { options } = nightlyCommitFixture({ releases: [nightly(0, { tag_name: "v1.0.0" })] });
-  await assert.rejects(resolveLatestNightlyCommit(options), /No published nightly/);
-});

.github/scripts/ci-changes.cjs

@@ -36,6 +36,7 @@ const EXTRA_OWNERS = [
   // scripts/build-desktop-artifact.ts reads the GNOME extension manifest.
   [/^apps\/desktop\/gnome-extension\//, ["@t3tools/scripts"]],
   [/^native\/browser-secret\//, ["@t3tools/desktop"]],
+  [/^native\/kde-snap-shot\//, ["@t3tools/desktop"]],
   [/^native\/libghostty-vt\//, ["@t3tools/web"]],
 ];
 const RUST = /^native\/(resource-monitor|kde-snap-shot|hyprland-snap-shot)\//;
@@ -112,10 +113,10 @@ function ownersOf(file, packages) {
   // A manifest can change dependencies or versions other packages read.
   if (path.posix.basename(file) === "package.json") return null;
   if (RUNS_EVERYTHING.some((pattern) => pattern.test(file))) return null;
+  const extra = EXTRA_OWNERS.flatMap(([pattern, names]) => (pattern.test(file) ? names : []));
   // scripts/build-desktop-artifact.test.ts reads the crates' sources.
-  if (RUST.test(file)) return ["@t3tools/scripts"];
+  if (RUST.test(file)) return ["@t3tools/scripts", ...extra];
 
-  const extra = EXTRA_OWNERS.flatMap(([pattern, names]) => (pattern.test(file) ? names : []));
   const owner = packages
     .filter((pkg) => file.startsWith(`${pkg.dir}/`))
     .sort((a, b) => b.dir.length - a.dir.length)[0];

.github/scripts/thread-transfer-report.cjs

@@ -244,10 +244,26 @@ async function resolve({ github, context, core }) {
 
   let pullNumber = source.pull_requests?.[0]?.number;
   if (!pullNumber) {
-    const associated = await github.paginate(
-      github.rest.repos.listPullRequestsAssociatedWithCommit,
-      { owner, repo, commit_sha: source.head_sha, per_page: 100 },
-    );
+    let associated;
+    try {
+      associated = await github.paginate(github.rest.repos.listPullRequestsAssociatedWithCommit, {
+        owner,
+        repo,
+        commit_sha: source.head_sha,
+        per_page: 100,
+      });
+    } catch (error) {
+      // A force-pushed or deleted PR head can disappear before this workflow runs.
+      if (
+        error.status === 422 &&
+        error.response?.data?.message === `No commit found for SHA: ${source.head_sha}`
+      ) {
+        core.info(`Skipping CI result for unavailable commit ${source.head_sha}.`);
+        core.setOutput("publish", "false");
+        return;
+      }
+      throw error;
+    }
     const matchingPulls = associated.filter(
       (pull) =>
         pull.state === "open" &&

.github/scripts/thread-transfer-report.test.cjs

@@ -2,7 +2,6 @@ const assert = require("node:assert/strict");
 const test = require("node:test");
 
 const {
-  renderComment,
   resolve,
   upsertCommentForCurrentHead,
   validateResult,
@@ -53,39 +52,6 @@ test("validates the fixed artifact schema", () => {
   );
 });
 
-test("renders baseline, impact, ceiling, and ceiling changes", () => {
-  const baseline = result();
-  const current = result({ measuredTurnWebSocketWireBytes: 260_000 });
-  current.providers.codex.ceiling = {
-    ...current.providers.codex.ceiling,
-    measuredTurnWebSocketWireBytes: 330_000,
-  };
-  const comment = renderComment({
-    current,
-    baseline,
-    currentRun: {
-      sha: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
-      conclusion: "success",
-      url: "https://github.com/pingdotgg/t3code/actions/runs/2",
-    },
-    baselineRun: {
-      sha: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-      matchesBase: true,
-      url: "https://github.com/pingdotgg/t3code/actions/runs/1",
-    },
-  });
-
-  assert.match(comment, /Main baseline \| This PR \| Impact \| PR ceiling/);
-  assert.match(comment, /\+9\.8 KiB \(\+4\.0%\)/);
-  assert.match(comment, /This PR changes transfer ceilings/);
-  assert.match(comment, /312\.5 KiB → 322\.3 KiB/);
-  assert.match(comment, /<!-- t3-thread-transfer-report -->/);
-  assert.match(
-    comment,
-    /<!-- t3-thread-transfer-result-sha:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb -->/,
-  );
-});
-
 test("resolves a fallback PR with a redacted head repo and exact main baseline", async () => {
   const outputs = {};
   const listWorkflowRunArtifacts = () => {};
@@ -216,6 +182,47 @@ test("does not guess when a fallback commit belongs to multiple PRs", async () =
   assert.equal(fetchedPull, false);
 });
 
+test("skips a missing PR commit but preserves other lookup failures", async () => {
+  for (const [status, message, shouldSkip] of [
+    [422, "No commit found for SHA: old-head", true],
+    [422, "Validation Failed", false],
+    [403, "API rate limit exceeded", false],
+  ]) {
+    const outputs = {};
+    const error = Object.assign(new Error(message), {
+      status,
+      response: { data: { message } },
+    });
+    const run = resolve({
+      github: {
+        paginate: async () => {
+          throw error;
+        },
+        rest: { repos: { listPullRequestsAssociatedWithCommit: () => {} } },
+      },
+      context: {
+        repo: { owner: "pingdotgg", repo: "t3code" },
+        payload: {
+          workflow_run: { event: "pull_request", head_sha: "old-head", pull_requests: [] },
+        },
+      },
+      core: {
+        info: () => {},
+        setOutput: (key, value) => {
+          outputs[key] = value;
+        },
+      },
+    });
+    if (shouldSkip) {
+      await run;
+      assert.equal(outputs.publish, "false");
+    } else {
+      await assert.rejects(run, (caught) => caught === error);
+      assert.deepEqual(outputs, {});
+    }
+  }
+});
+
 test("does not report a passing run that skipped the server tests", async () => {
   const outputs = {};
   const listWorkflowRunArtifacts = () => {};
@@ -332,21 +339,3 @@ test("preserves a successful result when a same-SHA rerun has no artifact", asyn
   assert.equal(published, true);
   assert.equal(updatedComment, false);
 });
-
-test("accepts V2 without comparing it to the V1 scenario", () => {
-  const current = result();
-  current.scenario.id = "thread-transfer-v2";
-  current.providers.codex.ceiling = { ...current.providers.codex.ceiling, totalWireBytes: 3000000 };
-  assert.equal(validateResult(current), current);
-  const comment = renderComment({
-    current,
-    baseline: result(),
-    currentRun: { sha: "bbbbbbbb", conclusion: "success", url: "https://example.com/current" },
-    baselineRun: { sha: "aaaaaaaa", matchesBase: true, url: "https://example.com/baseline" },
-  });
-  assert.match(comment, /fixture changed/);
-  assert.doesNotMatch(comment, /This PR changes transfer ceilings/);
-  assert.doesNotMatch(comment, /[+-]\d+\.\d+%/);
-  current.scenario.id = "unrecognized";
-  assert.throws(() => validateResult(current), /not supported/);
-});

.github/workflows/ci.yml

@@ -93,6 +93,9 @@ jobs:
       - name: Check generated GitHub GraphQL operations
         run: vp run --filter @t3tools/source-control-github generate --check
 
+      - name: Check generated Expo GraphQL operations
+        run: vp run --filter t3 generate --check
+
       - name: Check
         run: vp check
 
@@ -249,6 +252,7 @@ jobs:
 
   # The web suite is the largest outside the server. In the shared Test job it
   # started last and ran alone for about 40s after everything else finished.
+  # release.yml mirrors this test, test_web, and test_server split.
   test_web:
     name: Test Web
     needs: changes

.github/workflows/cursor-hygiene-webhook.yml

@@ -3,7 +3,9 @@ name: Forward to Cursor hygiene
 on:
   push:
     branches: [main]
-  pull_request:
+  # Use trusted workflow code and repository secrets for fork PRs.
+  # Keep this job payload-only: never check out or run PR code.
+  pull_request_target:
     types: [opened, reopened, ready_for_review]
   issues:
     types: [opened, closed, reopened]
@@ -34,7 +36,7 @@ jobs:
               --output /dev/null --write-out '%{http_code}' \
               -H "Authorization: $AUTH" \
               -H "Content-Type: application/json" \
-              -H "X-GitHub-Event: ${{ github.event_name }}" \
+              -H "X-GitHub-Event: ${{ github.event_name == 'pull_request_target' && 'pull_request' || github.event_name }}" \
               -H "X-GitHub-Delivery: ${{ github.run_id }}-${{ github.run_attempt }}" \
               --data-binary @"${{ github.event_path }}") || curl_status=$?
             if [ "$curl_status" -eq 0 ]; then

.github/workflows/deploy-relay.yml

@@ -41,6 +41,8 @@ jobs:
       RELAY_TUNNEL_ZONE_NAME: ${{ vars.RELAY_TUNNEL_ZONE_NAME }}
       RELAY_TUNNEL_CLEANUP_MODE: ${{ vars.RELAY_TUNNEL_CLEANUP_MODE }}
       RELAY_LEGACY_TUNNEL_CLEANUP_MODE: ${{ vars.RELAY_LEGACY_TUNNEL_CLEANUP_MODE }}
+      RELAY_ALERT_NOTIFIER_ID: ${{ vars.RELAY_ALERT_NOTIFIER_ID }}
+      RELAY_WARNING_NOTIFIER_ID: ${{ vars.RELAY_WARNING_NOTIFIER_ID }}
       CLERK_PUBLISHABLE_KEY: ${{ vars.CLERK_PUBLISHABLE_KEY }}
       CLERK_JWT_AUDIENCE: ${{ vars.CLERK_JWT_AUDIENCE }}
       APNS_ENVIRONMENT: ${{ vars.APNS_ENVIRONMENT }}