Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of rename class functionality #1818

Closed
andrii0lomakin opened this issue Nov 14, 2013 · 3 comments
Closed

Improve performance of rename class functionality #1818

andrii0lomakin opened this issue Nov 14, 2013 · 3 comments
Assignees
Milestone

Comments

@andrii0lomakin
Copy link
Member

During serialization of document we encode name of class of document as part of binary content. As result if we rename class and have big amount of data in database it becomes very very slow.

I can see following options:

  1. Set by convention that we can not mix records from different classes in one cluster (not so big problem I think) and do not encode class name in record it will be detected automatically. As result we will not have problems with rename and overhead of such detection can be very minimal.
  2. Set unique identifier for each class and use it for serialization/deserialilzation. This approach is more flexible and robust.

So we need to choose something ))

@lvca
Copy link
Member

lvca commented Nov 14, 2013

At the beginning the idea of layered independent blocks was sexy, but after few years how many people mix different records in the same cluster? I think you're right. This would reduce the record size, improve serialization performance and other operations like class rename. So +1 for me. The perfect place is 2.0 because it's a huge change.

@andrii0lomakin
Copy link
Member Author

Some users use single cluster for several classes approach. Here is use case https://groups.google.com/forum/#!topic/orient-database/ih6tOvL7w7A

@lvca
Copy link
Member

lvca commented Dec 2, 2013

We could remove this feature and oblige users to use OO inheritance by creating multiple classes ;-)

andrii0lomakin added a commit that referenced this issue Feb 18, 2014
@andrii0lomakin andrii0lomakin modified the milestones: 1.7rc2, 2.0 Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants