Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themeing #10

Closed
travankor opened this issue Feb 19, 2020 · 10 comments
Closed

Themeing #10

travankor opened this issue Feb 19, 2020 · 10 comments

Comments

@travankor
Copy link

Can you add a way to customize theme options? Something so that base-16 works? Example of how the format can look.

@orhun
Copy link
Owner

orhun commented Feb 20, 2020

So, are you suggesting to update the k3rmit config format according to the base-16?

@travankor
Copy link
Author

Actually, I missed the existing themeing colours. But can you add 256 color support (tput colors says 256)?

@orhun
Copy link
Owner

orhun commented Feb 20, 2020

Can you give an example about the color scheme you want to use?

@travankor
Copy link
Author

I tried to add

# extended base16 colors
color16 0xfe8019
color17 0xd65d0e
color18 0x3c3836
color19 0x504945
color20 0xbdae93
color21 0xebdbb2  

but I get fish: 'k3rmit' terminated by signal SIGSEGV (Address boundary error)

@orhun
Copy link
Owner

orhun commented Feb 20, 2020

okay I see, it's a bug due to the fixed size of termPalette variable. I'll check if GDK supports extended colors and keep this issue updated.

@orhun
Copy link
Owner

orhun commented Feb 20, 2020

unfortunately, vte_terminal_set_colors function does not support extended colors.

(k3rmit.o): VTE-CRITICAL **: 13:10:33.614: void vte_terminal_set_colors(VteTerminal*, const GdkRGBA*, const GdkRGBA*, const GdkRGBA*, gsize): assertion '(palette_size == 0) || (palette_size == 8) || (palette_size == 16) || (palette_size == 232) || (palette_size == 256)' failed

I'll keep looking for alternatives.

@travankor
Copy link
Author

What termite does if this helps

orhun added a commit that referenced this issue Mar 1, 2020
@orhun
Copy link
Owner

orhun commented Mar 1, 2020

I've changed the config file format and updated the palette size to 256. Can you try the extended colors now?

@orhun
Copy link
Owner

orhun commented Mar 1, 2020

@travankor
Copy link
Author

travankor commented Mar 1, 2020

Thanks! This works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants