Apply hide_from_bots also to WebDriver (Selenium) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling
hide_from_botswill now not only hide the plugin from crawler bots, but also from WebDriver (Selenium).The navigator.webdriver property is used for the detection.
This is useful when end to end tests using Selenium are used, and one don't want the plugin to be run on each page (thus triggering the banner, which would cover some portions of the tested webpage). Also WebDriver could itself be used as a tool for crawlers, so the semantics of the name of flag
hide_from_botsis still appropriate.