Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Level 3 rgba() color notation instead of Level 4 #49

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

alimony
Copy link
Contributor

@alimony alimony commented Aug 13, 2021

The rest of this file uses CSS Color Level 3 rgba() functional notation, but this one instance uses Level 4 notation. This causes an error in some preprocessors (I noticed it in my Jekyll Sass preprocessor). Might be better to go with the more common notation until Level 4 is better supported.

The rest of this file uses CSS Color Level 3 `rgba()` functional notation, but this one instance uses Level 4 notation. This causes an error in some preprocessors (I noticed it in my Jekyll Sass preprocessor). Might be better to go with the more common notation until Level 4 is better supported.
@orestbida
Copy link
Owner

sure 👍

@orestbida orestbida merged commit 26ca5b3 into orestbida:master Aug 13, 2021
@mmayernick
Copy link

I'm also seeing this issue. Confirmed that the fix from @alimony works, but it looks like it hasn't made it into the release branches yet. Would it be possible to update @orestbida?

@orestbida
Copy link
Owner

@mmayernick,

oh, my bad! It was very likely overwritten with a PR from a feature branch not up to date with the master branch. Will release a minor revision soon.

@orestbida orestbida mentioned this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants