Avoid renaming object properties in Closure compiler #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #113 we added getter for the config values.
However, it does not work properly. The reason is the minified version in
dist/
has the properties renamed, so the _config object actually looks something like this:So calls like
cc.getConfig('current_lang')
obviously won't work, because the property was renamed tog
.The reason is Closure compiler optimization. One option to avoid this is to have keys of the object quoted, see StackOverflow. Keys would then be preserved from the optimalization.
Another option would be to not use
ADVANCED_OPTIMIZATIONS
level on Closure and use just SIMPLE_OPTIMIZATIONS. However it would mean a little bit bigger output file.