-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: The preference modal bar layout is broken if button order is flipped #539
Comments
Can confirm this is a bug! Unfortunately the |
Ah, right – we dropped iOS < 15 a while ago, so we've been able to use
|
Unfortunately a consent management tool needs to have a reasonably wide browser support, so we're stuck with I don't know about specific browser ranges, probably all the browsers that support flexbox/grid and es6+. The oldest supported Safari version is 11.3. |
@orestbida Got it, thanks! Might be a good idea to explicitly define browser support using browserslist. |
yes!!! saying that v3 "Supports modern browsers only" is not helpful at all. a list with actual values would be good |
Expected Behavior
With the preferences modal set to
layout: bar
andflipButtons: true
, the button layout is broken:The
necessary
button has additional margin to the top and right, but this only works in the default button order.Current Behavior
Buttons lack spacing and are not of equal width.
Steps to reproduce
Use
layout: bar
andflipButtons: true
underguiOptions.preferencesModal
.Proposed fix or additional info.
This could be fixed by using
gap
instead ofmargin
to add some spacing between the buttons. This works regardless offlex-direction
orgrid-column
settings.Version
3.0.0-rc.15
On which browser do you see the issue?
Firefox
The text was updated successfully, but these errors were encountered: