Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible types in 2.8 version #349

Closed
literat opened this issue Jul 26, 2022 · 3 comments
Closed

Incompatible types in 2.8 version #349

literat opened this issue Jul 26, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@literat
Copy link

literat commented Jul 26, 2022

Hi,

we are upgrading from 2.8.0 to 2.8.3 version of this library and I came across some incompatible types that are used in this version.

Problems are caused by these types:

  • missing cookie_name key
  • missing level key in SavedCookieContent. This is renamed in version 3 to categories. The key categories is present in types.
  • required type cookie_table_headers in SettingsModalLanguageSetting, which, I think, should not be required, added in Fix types #335

I can help with fixing these issues and create pull-request to fix them. Please let me know if these are unintentional bugs that I could solve by adding those keys and making the last one not required.

Thank you for this library and your work on it ♥️

@orestbida
Copy link
Owner

Hi @literat,

since v2.8.1 the level field was (unintentionally) renamed to categories. v2.8.1 was released a few months after v2.8.0, and I completely forgot about this change — which was supposed to be present only in the v3 version.

saved_cookie_content = {
"categories": accepted_categories,
"revision": _config.revision,

At this point, reverting it back might not be a good idea, because it would create even more confusion.

@orestbida orestbida added the bug Something isn't working label Jul 26, 2022
literat added a commit to lmc-eu/cookieconsent that referenced this issue Jul 26, 2022
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Jul 26, 2022
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
@literat
Copy link
Author

literat commented Jul 26, 2022

@orestbida Ok, thanks for the explanation. I've updated the underlying PR to respect this change.

orestbida added a commit that referenced this issue Jul 26, 2022
Fix incompatible/missing types (refs #349)
@orestbida
Copy link
Owner

orestbida commented Jul 26, 2022

Thanks a lot for your contribution!

Will release a minor revision soon!

literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Aug 8, 2022
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Aug 9, 2022
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Aug 9, 2022
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Aug 9, 2022
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Jan 6, 2023
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Mar 9, 2023
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
literat added a commit to alma-oss/cookie-consent-manager that referenced this issue Jun 19, 2023
  * it was unintentionally renamed in v2.8.1 of cookieconsent library
  * @see: orestbida/cookieconsent#349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants