-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible types in 2.8 version #349
Comments
Hi @literat, since v2.8.1 the cookieconsent/src/cookieconsent.js Lines 1147 to 1149 in 819914c
At this point, reverting it back might not be a good idea, because it would create even more confusion. |
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
@orestbida Ok, thanks for the explanation. I've updated the underlying PR to respect this change. |
Fix incompatible/missing types (refs #349)
Thanks a lot for your contribution! Will release a minor revision soon! |
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
* it was unintentionally renamed in v2.8.1 of cookieconsent library * @see: orestbida/cookieconsent#349
Hi,
we are upgrading from 2.8.0 to 2.8.3 version of this library and I came across some incompatible types that are used in this version.
Problems are caused by these types:
cookie_name
keylevel
key inSavedCookieContent
. This is renamed in version 3 tocategories
. The keycategories
is present in types.cookie_table_headers
inSettingsModalLanguageSetting
, which, I think, should not be required, added in Fix types #335I can help with fixing these issues and create pull-request to fix them. Please let me know if these are unintentional bugs that I could solve by adding those keys and making the last one not required.
Thank you for this library and your work on it♥️
The text was updated successfully, but these errors were encountered: