Additional standard object specifications #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went through CiA301 and compared to the values there to what we've implemented. It's mostly correct, for the most part this just adds annotations for the data type (bit defs, units, limits) but there were two fixes of note: - 0x1200-0x3 unit32 -> uint8. Same as 89a208 did for 0x1280. - 0x1200 and 0x1280 are marked as RO in Table 74. The other instances of these records are RW (i.e. 0x1201 - 0x127F, 0x1281 - 0x12FF) but the first instances are RO.
ryanpdx
approved these changes
Nov 25, 2024
58f317f introduced _parse_bit_definitions and used it for _make_var, but _make_arr does its own var making so it was possible to let the old style bit definitions through. This fixes _make_arr. Should _make_arr just use _make_var like _make_rec? Should this go in a unit test? I don't really want to think about it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through CiA301 and compared the values there to what we've implemented. It's mostly correct, for the most part this just adds annotations for the data type (bit defs, units, limits) but there were two fixes of note: