Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish Translation #2448

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Add Spanish Translation #2448

merged 4 commits into from
Sep 19, 2023

Conversation

Psifour
Copy link
Contributor

@Psifour Psifour commented Sep 13, 2023

Translation by Zerone
Implementation into mdbook by Psifour

  • Added to language selection
  • Verified localization
  • Updated to 0.9 documentation
  • Added to just

Translation by Zerone
This resolves the use of Spanish words, like "todos", triggering the forbidden word filter.
@Psifour
Copy link
Contributor Author

Psifour commented Sep 13, 2023

Added all localization .po files within docs/po to the bin/forbid whitelist for the purposes of the forbidden word check. This check is intended to avoid inclusion (filtering for "todo" and dbg"), but conflicts with the use of similar words in other languages, like the word "todo" in Spanish.

Failed test appears to be flakey as no relevant code to it was changed in 49314d7

@raphjaph
Copy link
Collaborator

Added all localization .po files within docs/po to the bin/forbid whitelist for the purposes of the forbidden word check. This check is intended to avoid inclusion (filtering for "todo" and dbg"), but conflicts with the use of similar words in other languages, like the word "todo" in Spanish.

Yes, good add.

Failed test appears to be flakey as no relevant code to it was changed in 49314d7

Yeah on Windows there's one flaky test.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la magnífica traducción!

@raphjaph raphjaph enabled auto-merge (squash) September 19, 2023 10:13
@raphjaph raphjaph merged commit ebcc779 into ordinals:master Sep 19, 2023
6 checks passed
This was referenced Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants