Upgrade Groovy to 5.0.5 (Java 11+ required) - #79
Merged
Conversation
royteeuwen
commented
May 4, 2026
royteeuwen
commented
Contributor
- Bump groovy.version 4.0.31 -> 5.0.5
- Raise maven.compiler.source/target from 1.8 to 11 (Groovy 5 requires JDK 11+)
- Bump exported API package versions to 20.0.0 to satisfy bnd-baseline
- Update README compatibility section: 20.x requires Java 11/17/21, 19.x remains the line for Java 8 environments
- Bump project version to 20.0.0-SNAPSHOT
royteeuwen
force-pushed
the
feature/upgrade-groovy-5
branch
5 times, most recently
from
May 5, 2026 20:18
08d8aa2 to
91f23ed
Compare
- Bump groovy.version 4.0.31 -> 5.0.5 - Raise maven.compiler.source/target from 1.8 to 11 (Groovy 5 requires JDK 11+) - Bump exported API package versions to 20.0.0 - Update README compatibility section: 20.x requires Java 11/17/21, 19.x remains the line for Java 8 environments - Bump project version to 20.0.0-SNAPSHOT
Sling Starter ships a singleton config for org.apache.felix.hc.generalchecks.ServicesCheck (the systemalive check). Felix Configurator rejects mixing singleton + factory configs for the same base PID, so our factory config (~groovyconsole) was never materialized as an HC instance — silently failing to provide a groovyconsole-tagged health check at all. Removing the broken config. Bundle consumers that want a Groovy Console readiness check can register their own HealthCheck service in their environment if needed.
Sling Starter 14 hits an upstream NPE in Felix HTTP Jetty12 1.1.8 (WhiteboardContextHandler.getRegistry() null during a config update mid-startup) that intermittently corrupts the whiteboard registry, returning 404 for /system/health.json and any other whiteboard-managed servlets. Polling Felix HC for readiness is therefore unreliable. Switching the @BeforeAll wait to a no-op script POST against /bin/groovyconsole/post (Sling Engine routing, unaffected by the bug) plus a 15s stability window so we don't fire tests during the bundle refresh cascade. 300s overall timeout covers the slow-install variant where bundle resolution retries before the groovy host gets refreshed to 5.0.5.
royteeuwen
force-pushed
the
feature/upgrade-groovy-5
branch
from
May 5, 2026 20:31
91f23ed to
ac60ee4
Compare
|
Sling Starter 14 ships org.apache.felix.http.jetty12 1.1.8, which intermittently fails IT startup. Add a jetty12 feature file pinning 1.2.0 and an artifactsOverrides HIGHEST rule so it wins the clash. Remove once we move to Sling Starter 15.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.