-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify track reader manager and messenger use #1474
base: main
Are you sure you want to change the base?
Conversation
0aedce4
to
83dc8ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
+ Coverage 84.34% 84.37% +0.02%
==========================================
Files 120 121 +1
Lines 5449 5509 +60
==========================================
+ Hits 4596 4648 +52
- Misses 606 612 +6
- Partials 247 249 +2 ☔ View full report in Codecov by Sentry. |
b7b0a9a
to
d2ffbe7
Compare
d2ffbe7
to
6546b12
Compare
c1f4e72
to
04ede71
Compare
Signed-off-by: Terry Howe <[email protected]>
04ede71
to
f2066cc
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
I think I still want to pull something out of this. |
What this PR does / why we need it:
If we just pass the messenger to reader, it will be a lot easier to test these packages.
Partial: #1461
Partial: #1449