-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): release artifacts for freebsd #1192
Conversation
this commit adds support for oras on freebsd os. It adds make target for compiling oras binary on freebsd and updates goreleaser config to release for freebsd as well. Signed-off-by: Anurag <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 81.68% 81.73% +0.05%
==========================================
Files 68 68
Lines 3806 3806
==========================================
+ Hits 3109 3111 +2
+ Misses 489 487 -2
Partials 208 208 ☔ View full report in Codecov by Sentry. |
cc: @dfr |
I can test this on a FreeBSD system - I'll take a look later today. |
Looks good to me - it builds on FreeBSD natively and that build works well in my ad-hoc testing. I also ran unit tests on a FreeBSD host and that looks fine too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It would be nice to have arm64 binaries as well but I haven't tested that so perhaps that could be in a future followup. |
I verified that the build works on our freebsd 13.2 on amd64. Thanks! |
Thanks @tmaroschik for the verification! Hi @oras-project/oras-cli maintainers, any luck with reviewing or approving this PR? |
@FeynmanZhou We have one request above about arm64 binaries.
Do you want to proceed with that in this PR? The original issue was only about amd64 binaries, so I skipped other arch. |
I'm happy to move forward as-is and look into adding arm64 as a followup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I think it's would better to have all the compatible arch in this PR but else LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ORAS CLI will be guaranteed to build on FreeBSD(see Tier 2 in oras-project/oras-www#277).
Signed-off-by: Anurag <[email protected]> Signed-off-by: Feynman Zhou <[email protected]>
Adds support for oras on freebsd os. It adds make target for compiling oras binary on freebsd and updates goreleaser config to release for freebsd as well.
Note
I've not tested it on a freebsd system. I only tested go compiling the program to an executable.
make targets
goreleaser snapshot
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1179
Please check the following list: