Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight Registry with Oras OCI Layouts and Cloud Object Storage #253

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

WesselAtWork
Copy link
Contributor

As per @FeynmanZhou request I am working on writing up a proper blog post from this Discussion

Still WIP but created the initial skeleton and this pull request to track

@WesselAtWork
Copy link
Contributor Author

Feel free to suggest alternate titles.
Here are some of the top of my head:

  • OCI in the cloud
  • OCI-Registry on cloud storage
  • FUSEing the OCI-Registry and Cloud Storage Gap
  • Registry setup can be conFUSEing but it doesn't have to be!
  • Who needs a Registry Service when you have FUSE!
  • FUSEing your way to a lightweight OCI-Registry
  • ConFUSE artefact storage providers with this One Weird Trick!

@TerryHowe
Copy link
Member

You close on this?

@WesselAtWork
Copy link
Contributor Author

@TerryHowe yup.
Work has been brutal, still found some time to work on this.

Just need to figure out the graph color scheme for light and dark.
Am using svgs, do you have a concrete example for Docusaurus?
I found this i their docs x
But unsure of exactly how to do it.

@WesselAtWork WesselAtWork marked this pull request as ready for review October 9, 2023 22:26
@WesselAtWork
Copy link
Contributor Author

@TerryHowe

Again sorry for the long dev time,
It's ready for review.

@WesselAtWork
Copy link
Contributor Author

Had some issues with the theming on the svg graphs.
I had to bake in the stylesheet.
If anyone knows of a better why, please feel free to fix.

@TerryHowe
Copy link
Member

Still have a DCO problem. Might be easiest to git reset --soft HEAD~10 and git commit --signoff -am 'Lightweight registry with oras OCI layouts' or something of the sort

@TerryHowe
Copy link
Member

I don't know a ton about docusaurus, but maybe @asmitbm as some ideas

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple caps issues, but is should let you squash and DCO this first

blog/2023-10-14-lightweight-cloud-registry-oras/index.mdx Outdated Show resolved Hide resolved
blog/2023-10-14-lightweight-cloud-registry-oras/index.mdx Outdated Show resolved Hide resolved
blog/2023-10-14-lightweight-cloud-registry-oras/index.mdx Outdated Show resolved Hide resolved
blog/2023-10-14-lightweight-cloud-registry-oras/index.mdx Outdated Show resolved Hide resolved
blog/2023-10-14-lightweight-cloud-registry-oras/index.mdx Outdated Show resolved Hide resolved
Worked on intro

added AWS data

Updated Export Script

Added Local Plot

Expand findings

Slight Rewording

Breaks Local dev

Theming and Spell Check

rename

Signed-off-by: WesselAtWork <[email protected]>
@WesselAtWork WesselAtWork force-pushed the s3-blog branch 2 times, most recently from e6628df to 89b1d7e Compare October 11, 2023 10:00
Signed-off-by: WesselAtWork <[email protected]>
Copy link
Member

@asmitbm asmitbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @WesselAtWork the SVGs appear to be working fine. Do you have any issue right now?

@WesselAtWork
Copy link
Contributor Author

WesselAtWork commented Oct 12, 2023

Hey @WesselAtWork the SVGs appear to be working fine. Do you have any issue right now?

No issue.
I just don't like what I did.
I hard coded the theme scripts into the svg files, not good, but I don't know if there is an alternative way if you are embedding the svgs inside of an <img>.

@WesselAtWork
Copy link
Contributor Author

WesselAtWork commented Oct 12, 2023

Oh wait.

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?xml-stylesheet type="text/css" href="/styles.css"?>
<svg ...>
  <... />
</svg>

ref

With modified custom.css

svg text {
  font-family: var(--ifm-font-heading-family);
  fill: #FF0000;
}

svg .realtime-body {
  fill: #FF0000;
}

RED used as a "it works" (very obvious)
font family used to test variables

Kinda works.
It only works right-click-open-in-a-new-tab the SVG in the browser, might actually be a browser bug?
spec uses a lot of words but it kind sound like it should work?
Right now, embedded styles work in an embedded <img> svg, context from the browser works (switching themes), why doesn't linking css sheets work?

Also tested:

<style>
  @import url(http://localhost:3000/styles.css);
</style>

Works in it's own tab, not embedded in <img>

@WesselAtWork
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#security_and_privacy_concerns
https://stackoverflow.com/a/64986781

Unless there an easy way to inject the style-sheet statically into the svg, it looks like this is not going to happen :(
Hard coded css it is.

@WesselAtWork
Copy link
Contributor Author

@TerryHowe

Anything stopping this from being merged in?

@WesselAtWork
Copy link
Contributor Author

@FeynmanZhou

Anything holding this one back?

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to put more time into this.

Co-authored-by: Terry Howe <[email protected]>
Signed-off-by: WesselAtWork <[email protected]>
Signed-off-by: WesselAtWork <[email protected]>
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@asmitbm asmitbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asmitbm asmitbm merged commit a012e67 into oras-project:main Jan 7, 2024
6 checks passed
TerryHowe added a commit to TerryHowe/oras-www that referenced this pull request Jul 21, 2024
…ras-project#253)

As per @FeynmanZhou request I am working on writing up a proper blog
post from this [Discussion
](oras-project/oras#1067)

Still WIP but created the initial skeleton and this pull request to
track

---------

Signed-off-by: WesselAtWork <[email protected]>
Co-authored-by: Terry Howe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants