Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : created interfaces #10

Merged
merged 15 commits into from
Apr 20, 2023
Merged

feat : created interfaces #10

merged 15 commits into from
Apr 20, 2023

Conversation

sammychinedu2ky
Copy link
Member

This tries to resolve this issue
#3
Yet to create the Copy type

Wwwsylvia
Wwwsylvia requested changes Mar 24, 2023
View reviewed changes
OrasDotNet/Models/Descriptor.cs Outdated Show resolved Hide resolved
OrasDotNet/Models/DescriptorOCI.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/IStorage.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/ITagResolver.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/ITagResolver.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/ITarget.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/ITarget.cs Outdated Show resolved Hide resolved
OrasDotNet/Models/Errors/AlreadyExistsException.cs Outdated Show resolved Hide resolved
OrasDotNet/Models/Errors/AlreadyExistsException.cs Outdated Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

BTW should the title starts with "feat: "?

@Wwwsylvia Wwwsylvia mentioned this pull request Mar 24, 2023
Closed
@sammychinedu2ky sammychinedu2ky changed the title chore : created interfaces feat : created interfaces Mar 24, 2023
shizhMSFT
shizhMSFT reviewed Mar 27, 2023
View reviewed changes
OrasDotNet/OrasDotNet.csproj Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/IResolver.cs Outdated Show resolved Hide resolved
OrasDotNet/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
OrasDotNet/Models/Descriptor.cs Outdated Show resolved Hide resolved
OrasDotNet/Models/Descriptor.cs Outdated Show resolved Hide resolved
Wwwsylvia
Wwwsylvia reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the project and the namespaces as @shizhMSFT mentioned?

@sammychinedu2ky
Copy link
Member Author

Yh I think that would be a great idea

1 similar comment
@sammychinedu2ky
Copy link
Member Author

Yh I think that would be a great idea

Wwwsylvia
Wwwsylvia requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the directory name? Also please document all codes in comments.

Wwwsylvia
Wwwsylvia approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sammychinedu2ky Please fix the DCO.

Oras/Interfaces/IResolver.cs Outdated Show resolved Hide resolved
@sammychinedu2ky
Copy link
Member Author

Please fix the DCO.

Thanks @Wwwsylvia .. its fixed now

sammychinedu2ky and others added 15 commits April 17, 2023 04:25
@sammychinedu2ky
chore : created interfaces
2f2a94e 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
chore : added the descriptoroci type
9d8ebc5 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky @Wwwsylvia
Update OrasDotNet/Interfaces/IReadOnlyStorage.cs
cd93fa2 
Co-authored-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky @Wwwsylvia
Update OrasDotNet/Interfaces/ITagResolver.cs
68abb9d 
Co-authored-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
feat : added extra interfaces and made some changes to types
77b3b96 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
made changes to Error definitions and made changes to file name
9ef0b71 
Signed-off-by: Samson Amaugo <[email protected]>

Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
Added error messages to Exception Namespace
f400846 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
fix: used Interface instead of Class
28a747a 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
changed namespace to Oras
7f5ceda 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
made some changes to the namespace
80ac73e 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
remove directory
231c633 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
added document comments to ITarget
74a40a7 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
added comments
8239f7f 
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky @Wwwsylvia
Update Oras/Interfaces/IResolver.cs
64eff54 
Co-authored-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Samson Amaugo <[email protected]>
@sammychinedu2ky
fix: changed docs comment
0fd2651 
Signed-off-by: Samson Amaugo <[email protected]>
@Wwwsylvia Wwwsylvia merged commit c797022 into oras-project:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT left review comments

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammychinedu2ky @Wwwsylvia @shizhMSFT