Update OCI Discover Extension Response #95
Conversation
Signed-off-by: Akash Singhal <[email protected]>
akashsinghal
force-pushed
the
akashsinghal/updateRC1Discover
branch
from
6e35a25 to
7f00a3f
Compare
manifest-referrers-api.md
Outdated
| @@ -34,8 +34,11 @@ Content-Type: application/json | |||
| "extensions": [ | |||
| { | |||
| "name": "cncf.oras.referrers", | |||
| "url": "https://github.com/opencontainers/distribution-spec/blob/main/extensions/_oci.md", | |||
There was a problem hiding this comment.
The value for url description should be this this repo. You can just use the repo root.
Actually it’s https://oras.land
There was a problem hiding this comment.
ok I'll switch it to https://oras.land
There was a problem hiding this comment.
URL link to the documentation defining this extension and its endpoints.
Shouldn't this be the url of the spec? https://github.com/oras-project/artifacts-spec/blob/main/manifest-referrers-api.md
There was a problem hiding this comment.
The value is currently only a place holder and the definition in the extension spec is
url string, REQUIRED
URL link to the documentation defining this extension and its endpoints.
I think cloud providers can point to their own docs location.
Signed-off-by: Akash Singhal <[email protected]>
|
Recommend fixing this and backporting to RC1 branch since this makes sure that clients can use the correct property to get the referrers URL. |
* update oci discover extension response to match distribution spec * fix documentation url Signed-off-by: Akash Singhal <[email protected]>
* update oci discover extension response to match distribution spec * fix documentation url Signed-off-by: Akash Singhal <[email protected]>
endpointsfield and updatedurl