-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporting synchronized call and fix running in child thread #75
Conversation
Initialize this addon to be context-aware.
this also fixes context issue when running in child processes. |
This looks good to me, can it be merged in? |
@danielsokolowski the example are in the readme, you can avoid using a callback. |
May be the sync functions need to be separate than the async functions so we don't loose the async functionality |
@oransel I believe this change is fully backward compatible, it will use async method if you pass in a callback, otherwise it will do sync call. how else could we separate the sync methods? |
@z-hao-wang Sounds good. If you can resolve the merge conflicts, i can pull in and test. |
@oransel Just merged conflicts and test on my side worked. |
see readme examples