OWLS-99679 - Fix ItKubernetesDomainEvents.testDomainK8sEventsProcessingFailed test failure #3158
Conversation
…l value in Kubernetes
…l value in Kubernetes
doxiao
left a comment
doxiao
left a comment
There was a problem hiding this comment.
LGTM, just one minor nit.
My observation is that the test case used to fail occasionally, but started to fail consistently recently. I am curious about if we have an explanation for that.
| } | ||
|
|
||
| @Test | ||
| void whenJobInProgressAndINullIntrospectVersionUnchanged_doNotCreateNewJob() { |
There was a problem hiding this comment.
Typo in the method name - xxxAndINullInxxx.
When the test passes, I notice that the introspector pod with invalid pvc would fail after DeadlineExceeded and thus the introspection with the corrected pvc could start. |
|
Kudos, SonarCloud Quality Gate passed! |
…ngFailed test failure (oracle#3158) * restart introspector job if existing job is for a different introspectVersion
…ngFailed test failure (#3158) * restart introspector job if existing job is for a different introspectVersion
3 participants
Cause:
Test intentionally patches domain with non-existing pvc with updated introspectVersion to trigger introspection.
It then patches domain with correct pvc and updated introspectVersion to trigger another introspection.
However, the introspection pod for the first introspector job with non-existing pvc sometimes stayed in
PENDINGphase for a long time,with condition type
PODSCHEDULEDand reasonUnschedulable.This causes the introspection for the corrected pvc to not run before the test timed out waiting for the Completed event.
Fix:
In
VerifyIntrospectorJobResponseStep, if the job read from the readJob call is a job for a different introspectVersion,delete the current job and restart new one.
This involves adding
weblogic.introspectVersionlabel to the metadata of the introspector job.Update introspectVersion documentation to mention that its value must be a valid label value in Kubernetes, since operator also uses introspectVersion in metadata labels in weblogic-domain-introspect-cm ConfigMap and server pods.
Test testIntrospectDomainScript() in ItIntrospectVersion is using an invalid introspectVersion value of "My Version". It is updated to use a valid value of "My_Version-1".
jenkins: https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10963/