Skip to content

create wls-srg profile for a minimal wko certification #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Feb 14, 2022
Merged

create wls-srg profile for a minimal wko certification #2767

merged 27 commits into from
Feb 14, 2022

Conversation

@xiancao
Copy link
Contributor

@xiancao xiancao commented Feb 7, 2022 •
edited
Loading

xiancao added 16 commits January 26, 2022 04:35
@xiancao
create wls-srg profile
1d08f2e
@xiancao
add wls-srg profile
eb41716
@xiancao
create wls-srg profile
92a05d6
@xiancao
get the latest release/3.3
98c7818
@xiancao
cleanup
bb61261
@xiancao
resolve merge conflicts
de86c9f
@xiancao
fix syntax error
45d7f3c
@xiancao
restore jenkinsScript.sh
dea42d3
@xiancao
Merge branch 'release/3.3' of https://github.com/oracle/weblogic-kube…
1e4515b 
…rnetes-operator into xc-96069
@xiancao
add more tests to wls-srg
c1520a8
@xiancao
add more tests to wls-srg
0a778cd
@xiancao
get latest release/3.3
a0f206f
@xiancao
add more tests to wls-srg
4d87885
@xiancao
Merge branch 'release/3.3' of https://github.com/oracle/weblogic-kube…
e9febd2 
…rnetes-operator into xc-96069
@xiancao
fix class name
06a19fc
@xiancao
Merge branch 'release/3.3' of https://github.com/oracle/weblogic-kube…
304fa44 
…rnetes-operator into xc-96069
anpanigr
anpanigr reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the class name as follows ...
ItParameterizedDomainNoLB.java --> ItParameterizedDomains.java
ItParameterizedDomain.java --> ItParameterizedDomainsWithLoadBalancer.java

@xiancao xiancao requested a review from anpanigr February 7, 2022 23:08
@anpanigr
Copy link
Member

anpanigr commented Feb 8, 2022

(a) Can you make the similar change to the file ItParameterizedDomainWithLoadBalancer.java
(1) Modify the test class description (2) Use the default domain resource value (b) Modify the scaling test case name

(b) Need to modify the kindtest.sh to exclude ItParameterizedDomain class when no profile is selected see line 314

(c) Re(run) the jenkin job with new profile after the change

anpanigr
anpanigr reviewed Feb 8, 2022
View reviewed changes
anpanigr
anpanigr reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove crio-pipeline profile

@xiancao xiancao requested a review from anpanigr February 9, 2022 16:47
anpanigr
anpanigr approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiancao xiancao requested a review from anpanigr February 10, 2022 23:59
@anpanigr
Copy link
Member

anpanigr commented Feb 11, 2022

Sorry for last minute suggestion
Can you rename ItParameterizedDomain.java to ItMultiDomainModels.java to reflect the use cases
and ItParameterizedDomainWithLoadBalancer.java to ItMultiDomainModelsWithLoadBalancer.java

vanajamukkara
vanajamukkara reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@vanajamukkara vanajamukkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, suggested some minor changes

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/DomainUtils.java Outdated
* @param replicaCount - repica count of the clsuter
* @return oracle.weblogic.domain.Domain object
*/
public static Domain createDomainOnPVAndVerify(String domainUid,
Copy link
Contributor

@vanajamukkara vanajamukkara Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static Domain createDomainOnPVAndVerify(String domainUid,
public static Domain createDomainOnPVAndVerify(String domainUid,
Suggested change
public static Domain createDomainOnPVAndVerify(String domainUid,
public static Domain createDomainResourceForDomainOnPV(String domainUid,

Copy link
Contributor Author

@xiancao xiancao Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/DomainUtils.java Outdated

// Verify the domain custom resource is created.
// Also verify the admin server pod and managed server pods are up and running.
createDomainAndVerify(domainUid, domain, domainNamespace, domainUid + "-" + ADMIN_SERVER_NAME_BASE,
Copy link
Contributor

@vanajamukkara vanajamukkara Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this from here and call it from createDomainOnPvUsingWdt instead

Copy link
Contributor Author

@xiancao xiancao Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/DomainUtils.java Outdated
.domainType(WLS_DOMAIN_TYPE))
.introspectorJobActiveDeadlineSeconds(300L)));
setPodAntiAffinity(domain);
createDomainAndVerify(domain, domainNamespace);
Copy link
Contributor

@vanajamukkara vanajamukkara Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call createDomainAndVerify(String domainUid, Domain domain,
String domainNamespace, String adminServerPodName,
String managedServerPodNamePrefix, int replicaCount) and remove the code to check pods

Copy link
Contributor Author

@xiancao xiancao Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/DomainUtils.java Outdated
* @param replicaCount replica count of the cluster
* @return oracle.weblogic.domain.Domain object
*/
public static Domain createDomainInImageAndVerify(String domainUid,
Copy link
Contributor

@vanajamukkara vanajamukkara Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make similar changes here - change method name to createDomainResourceForDomainInImage and move createDomainAndVerify outside

Copy link
Contributor Author

@xiancao xiancao Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

anpanigr
anpanigr approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@anpanigr anpanigr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertpatrick robertpatrick merged commit 396ec74 into release/3.3 Feb 14, 2022
@robertpatrick robertpatrick deleted the xc-96069 branch February 14, 2022 18:32
xiancao added a commit that referenced this pull request Feb 15, 2022
@xiancao
create wls-srg profile for a minimal wko certification (#2767)
c996bba 
* create wls-srg profile

* add wls-srg profile

* create wls-srg profile

* cleanup

* resolve merge conflicts

* fix syntax error

* restore jenkinsScript.sh

* add more tests to wls-srg

* add more tests to wls-srg

* add more tests to wls-srg

* fix class name

* address Pani's comments

* update copyright

* address Pani's comments

* address Pani's comments

* address Vanaja's comments

* cleanup

* address Pani's comments

* address Pani's comments

* address Vanaja's comments
robertpatrick pushed a commit that referenced this pull request Feb 27, 2022
@xiancao
backport create wls-srg profile for a minimal wko certification to ma…
ed01014 
…in (#2787)

* create wls-srg profile for a minimal wko certification (#2767)

* create wls-srg profile

* add wls-srg profile

* create wls-srg profile

* cleanup

* resolve merge conflicts

* fix syntax error

* restore jenkinsScript.sh

* add more tests to wls-srg

* add more tests to wls-srg

* add more tests to wls-srg

* fix class name

* address Pani's comments

* update copyright

* address Pani's comments

* address Pani's comments

* address Vanaja's comments

* cleanup

* address Pani's comments

* address Pani's comments

* address Vanaja's comments

* update kindtest
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Jun 7, 2023
@xiancao
create wls-srg profile for a minimal wko certification (oracle#2767)
ed0a6f5 
* create wls-srg profile

* add wls-srg profile

* create wls-srg profile

* cleanup

* resolve merge conflicts

* fix syntax error

* restore jenkinsScript.sh

* add more tests to wls-srg

* add more tests to wls-srg

* add more tests to wls-srg

* fix class name

* address Pani's comments

* update copyright

* address Pani's comments

* address Pani's comments

* address Vanaja's comments

* cleanup

* address Pani's comments

* address Pani's comments

* address Vanaja's comments
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Jun 7, 2023
@xiancao
create wls-srg profile for a minimal wko certification (oracle#2767)
d96752d 
* create wls-srg profile

* add wls-srg profile

* create wls-srg profile

* cleanup

* resolve merge conflicts

* fix syntax error

* restore jenkinsScript.sh

* add more tests to wls-srg

* add more tests to wls-srg

* add more tests to wls-srg

* fix class name

* address Pani's comments

* update copyright

* address Pani's comments

* address Pani's comments

* address Vanaja's comments

* cleanup

* address Pani's comments

* address Pani's comments

* address Vanaja's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maggiehe00 maggiehe00 Awaiting requested review from maggiehe00

2 more reviewers

@anpanigr anpanigr anpanigr approved these changes

@vanajamukkara vanajamukkara vanajamukkara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xiancao @anpanigr @vanajamukkara @robertpatrick