Skip to content

OWLS-95390 - Add validation check to reject domain configurations that use same serverNamePrefix for multiple clusters. #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

OWLS-95390 - Add validation check to reject domain configurations that use same serverNamePrefix for multiple clusters. #2695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion operator/src/main/resources/scripts/introspectDomain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2018, 2021, Oracle and/or its affiliates.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
#
# ------------
Expand Down Expand Up @@ -351,6 +351,7 @@ def validate(self):
self.validateAdminServer()
self.validateClusters()
self.validateServerCustomChannelName()
self.validateDynamicClustersDuplicateServerNamePrefix()
return self.isValid()

def generate(self):
Expand Down Expand Up @@ -401,6 +402,15 @@ def validateAdminServer(self):
if cluster is not None:
self.addError("The admin server " + self.name(adminServer) + " belongs to the WebLogic cluster " + self.name(cluster) + ", the operator does not support having an admin server participate in a cluster.")

def validateDynamicClustersDuplicateServerNamePrefix(self):
serverNamePrefixes = []
for cluster in self.env.getDomain().getClusters():
if self.getDynamicServersOrNone(cluster) is not None:
if cluster.getDynamicServers().getServerNamePrefix() in serverNamePrefixes:
self.addError("The ServerNamePrefix '" + cluster.getDynamicServers().getServerNamePrefix() + "' specified for WebLogic dynamic cluster " + self.name(cluster) + "'s dynamic servers is already in use. The ServerNamePrefix must be unique for each WebLogic dynamic cluster.")
else:
serverNamePrefixes.append(cluster.getDynamicServers().getServerNamePrefix())

def validateClusters(self):
for cluster in self.env.getDomain().getClusters():
self.validateCluster(cluster)
Expand Down