-
Notifications
You must be signed in to change notification settings - Fork 216
Add support for operator labels and annotations #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,36 @@ imagePullSecrets: | |
| - name: "my-image-pull-secret" | ||
| ``` | ||
|
|
||
| ##### `annotations` | ||
| Specifies a set of key-value annotations that will be added to each pod running the operator. If no customer defined annotations are required, then omit this property. | ||
|
|
||
| Example: | ||
| ```yaml | ||
| annotations: | ||
| stage: production | ||
| ``` | ||
|
|
||
| You may also specify annotations [using the "--set" parameter to the Helm install command](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing), as follows: | ||
|
|
||
| ``` | ||
| --set annotations.stage=production | ||
| ``` | ||
|
|
||
| ##### `labels` | ||
| Specifies a set of key-value labels that will be added to each pod running the operator. The Helm chart will automatically add any required labels, so the customer is not required to define those here. If no customer defined labels are required, then omit this property. | ||
|
|
||
| Example: | ||
| ```yaml | ||
| labels: | ||
| sidecar.istio.io/inject: "false" | ||
| ``` | ||
|
|
||
| You may also specify labels [using the "--set" parameter to the Helm install command](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing), as follows: | ||
|
|
||
| ``` | ||
| --set labels."sidecar\.istio\.io/inject"=false | ||
| ``` | ||
|
|
||
| ##### `nodeSelector` | ||
| Allows you to run the operator Pod on a Node whose labels match the specified `nodeSelector` labels. You can use this optional feature if you want the operator Pod to run on a Node with particular labels. See [Assign Pods to Nodes](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) in the Kubernetes documentation for more details. This is not required if the operator Pod can run on any Node. | ||
|
|
||
|
|
@@ -137,8 +167,8 @@ nodeSelector: | |
| disktype: ssd | ||
| ``` | ||
|
|
||
| ##### `nodeAffinity` | ||
| Allows you to constrain the operator Pod to be scheduled on a Node with certain labels; it is conceptually similar to `nodeSelector`. `nodeAffinity` provides advanced capabilities to limit Pod placement on specific Nodes. See [Assign Pods to Nodes](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity) in the Kubernetes documentation for more details. This is optional and not required if the operator Pod can run on any Node or when using `nodeSelector`. | ||
| ##### `affinity` | ||
| Allows you to constrain the operator Pod to be scheduled on a Node with certain labels; it is conceptually similar to `nodeSelector`. `affinity` provides advanced capabilities to limit Pod placement on specific Nodes. See [Assign Pods to Nodes](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#node-affinity) in the Kubernetes documentation for more details. This is optional and not required if the operator Pod can run on any Node or when using `nodeSelector`. | ||
|
||
|
|
||
| Example: | ||
| ```yaml | ||
|
|
@@ -260,7 +290,7 @@ domainNamespaceLabelSelector: environment notin (production,systemtest) | |
|
|
||
| {{% notice note %}} | ||
| To specify the above sample on the Helm command line, escape spaces and commas as follows: | ||
| ```yaml | ||
| ``` | ||
| --set "domainNamespaceLabelSelector=environment\\ notin\\ (production\\,systemtest)" | ||
| ``` | ||
| {{% /notice %}} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"--set" -> Is it possible for this parameter to be in code font,
--set? (I forget if it does or does not render correctly when inside a x-ref.) If it works, please make the same edit in thelabelssection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done