owls-87625 - Remove stranded old named node port service for the domain when deleting and replacing service #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leting and replacing service.
doxiao
reviewed
Feb 19, 2021
operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java
Outdated
Show resolved
Hide resolved
operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java
Show resolved
Hide resolved
operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java
Outdated
Show resolved
Hide resolved
alai8
reviewed
Feb 20, 2021
operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java
Outdated
Show resolved
Hide resolved
alai8
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
owls-87625 - Operator 3.0.1 version created external NodePort service with "-external" suffix. Operator 3.1.x creates the external NodePort service with shorter name with "-ext" suffix. This is causing an issue when upgrading the Operator from 3.0.1 to 3.1.1 and changing the
restartVersion. This is because the port for the external NodePort service created by Operator 3.1.1 is already in use by the NodePort service created by Operator 3.0.1 with the old name (with "-external" suffix).This change removes stranded old named node port service during the service replace call by listing services of NodePort type created by the Operator for this particular domain. It deletes the node port service returned by the list call and then replaces it with the new name. Integration test results - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4105/