Skip to content

Conversation

@alai8
Copy link
Member

@alai8 alai8 commented Dec 14, 2020

When a replicas value is below the configured min cluster size, or above the configured max cluster size, generate events such as:

Events:

5s          Warning   DomainValidationError       domain/domain1   Validation error in domain resource domain1: Replica request of 2,020 exceeds the maximum dynamic server count of 2 configured for cluster cluster-1

9s          Warning   DomainValidationError       domain/domain1   Validation error in domain resource domain1: Replica request of 0 less than the minimum dynamic server count of 1 configured for cluster cluster-1

Also update status.message of the domain resource to:

"Replica request of 2,020 exceeds the maximum dynamic server count of 2 configured for cluster cluster-1"

"Replica request of 0 less than the minimum dynamic server count of 1 configured for cluster cluster-1"

Also include in the PR a fix for a bug that was found in validation of serverName of specified in managedServer, in that a validation warning message such as the following is added even though the server name exists in a dynamic cluster:

"Managed Server 'managed-server1' specified in the domain resource does not exist in the WebLogic domain home configuration."

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3334/

@alai8 alai8 requested a review from mriccell December 14, 2020 17:27
Copy link
Member

@doxiao doxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment.

Events: <none>
```
Example of a `InvalidReplicasValue` event:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change InvalidReplicasValue to DomainValidationError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. updated with example of DomainValidationError.

@rjeberhard
Copy link
Member

@tbarnes-us, are your concerns addressed?

@tbarnes-us
Copy link

General comment: @alai8 Please file a JIRA for an 'unhappy path' IT test to test this change across a couple of simple representative failure cases. I think @sankarpn is already testing other unhappy paths, so loop him in.

@rjeberhard rjeberhard merged commit 31e7ec9 into develop Dec 18, 2020
@alai8 alai8 deleted the owls72816 branch December 18, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants