-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new C APIs used by the new json release #1856
Conversation
src/main/c/cext/ruby.c
Outdated
@@ -4715,7 +4715,7 @@ void rb_define_virtual_variable(const char *name, VALUE (*getter)(ANYARGS), void | |||
} | |||
|
|||
void rb_gc_register_mark_object(VALUE obj) { | |||
rb_tr_error("rb_gc_register_mark_object not implemented"); | |||
RUBY_CEXT_INVOKE("rb_gc_register_mark_object", obj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: this could be RUBY_INVOKE_NO_WRAP()
to avoid wrapping the return value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean RUBY_CEXT_INVOKE_NO_WRAP
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed.
Thanks!
I wonder what depends on the We could also ask for a new |
That would be great 👍 |
That's unfortunately not so easy because we actually declare and define the function. |
|
…nly_p (#1856). PullRequest: truffleruby/1195
Without these fixes essentially the entire Ruby ecosystem seems to stop working!
Shopify#1