Latest updates #59
Merged
Latest updates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`baremetal_core_subnet.security_list_ids` with multiple items causes destroy/add on every `terraform apply`, even with no changes. API state does not respect item ordering, so config and API state do not match (except when items happen to have exactly the same sorting as used by API state). Because local and remote state do not match, terraform will attempt to change remote state to match on every `apply`. Change `security_list_ids` from `TypeList` to `TypeSet`, so terraform only considers membership, not ordering. Fixes oracle#44
subnet: fix security_list_ids ordering
go fmt, imports
kilokahn
added
the
listVsSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50, Closes #44, Closes #49.
It also makes route table attributes optional, which I believe will resolve #34.
It also adds documentation for iscsi attributes, Closes #12.