Support compartment renaming #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Denormalize not really normal shared schemas in helpers_identity + policy + compartments * remove dead code/schema defs in helpers_identity * fix some copy/paste errors in related docs/datasources
codycushing
force-pushed
the
cush-compartment-rename
branch
from
ea3d138
to
f37f28b
Compare
| "id": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| ForceNew: true, |
There was a problem hiding this comment.
Does ForceNew make any difference for ID?
There was a problem hiding this comment.
Yeah thats a little weird.. not settable field to begin with, results in tf error--removed.
| @@ -53,11 +53,11 @@ func (s *ResourceIdentityCompartmentTestSuite) TestAccResourceIdentityCompartmen | |||
| { | |||
| Config: s.Config + ` | |||
| resource "oci_identity_compartment" "t" { | |||
| name = "-tf-compartment" | |||
| name = "-tf-compartment2" | |||
| description = "tf test compartment2" | |||
| }`, | |||
| Check: resource.ComposeTestCheckFunc( | |||
There was a problem hiding this comment.
This would have passed before the rename changes, right? Should check that the ID in fact stays the same.
…ompartment * Remove force new from immutable resource id field
briangustafson
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests
ccushing-mac:terraform-provider-oci ccushing$ make test run=Test.*Identity.*TestSuite
=== RUN TestDatasourceIdentityAPIKeysTestSuite
=== RUN TestAccDatasourceIdentityAPIKeys_basic
--- PASS: TestAccDatasourceIdentityAPIKeys_basic (3.45s)
--- PASS: TestDatasourceIdentityAPIKeysTestSuite (3.45s)
=== RUN TestDatasourceIdentityAvailabilityDomainsTestSuite
=== RUN TestAccIdentityAvailabilityDomains_basic
--- PASS: TestAccIdentityAvailabilityDomains_basic (0.30s)
--- PASS: TestDatasourceIdentityAvailabilityDomainsTestSuite (0.30s)
=== RUN TestDatasourceIdentityCompartmentsTestSuite
=== RUN TestAccIdentityCompartments_basic
--- PASS: TestAccIdentityCompartments_basic (2.46s)
--- PASS: TestDatasourceIdentityCompartmentsTestSuite (2.46s)
=== RUN TestDatasourceIdentityGroupsTestSuite
=== RUN TestAccDatasourceIdentityGroups_basic
--- PASS: TestAccDatasourceIdentityGroups_basic (4.49s)
--- PASS: TestDatasourceIdentityGroupsTestSuite (4.49s)
=== RUN TestDatasourceIdentityPoliciesTestSuite
=== RUN TestAccDatasourceIdentityPolicies_basic
--- PASS: TestAccDatasourceIdentityPolicies_basic (6.05s)
--- PASS: TestDatasourceIdentityPoliciesTestSuite (6.05s)
=== RUN TestDatasourceIdentitySwiftPasswordsTestSuite
=== RUN TestAccDatasourceIdentitySwiftPasswords_basic
--- PASS: TestAccDatasourceIdentitySwiftPasswords_basic (2.27s)
--- PASS: TestDatasourceIdentitySwiftPasswordsTestSuite (2.27s)
=== RUN TestDatasourceIdentityUserGroupMembershipsTestSuite
=== RUN TestAccIdentityUserGroupMemberships_basic
--- PASS: TestAccIdentityUserGroupMemberships_basic (7.98s)
--- PASS: TestDatasourceIdentityUserGroupMembershipsTestSuite (7.98s)
=== RUN TestDatasourceIdentityUsersTestSuite
=== RUN TestAccIdentityUsers_basic
--- PASS: TestAccIdentityUsers_basic (3.70s)
--- PASS: TestDatasourceIdentityUsersTestSuite (3.70s)
=== RUN TestResourceIdentityAPIKeyTestSuite
=== RUN TestAccResourceIdentityAPIKey_basic
--- PASS: TestAccResourceIdentityAPIKey_basic (1.71s)
--- PASS: TestResourceIdentityAPIKeyTestSuite (1.71s)
=== RUN TestResourceIdentityCompartmentTestSuite
=== RUN TestAccResourceIdentityCompartment_basic
--- PASS: TestAccResourceIdentityCompartment_basic (1.65s)
--- PASS: TestResourceIdentityCompartmentTestSuite (1.65s)
=== RUN TestResourceIdentityGroupTestSuite
=== RUN TestAccResourceIdentityGroup_basic
--- PASS: TestAccResourceIdentityGroup_basic (3.87s)
--- PASS: TestResourceIdentityGroupTestSuite (3.87s)
=== RUN TestResourceIdentityPolicyTestSuite
=== RUN TestAccResourceIdentityPolicy_basic
--- PASS: TestAccResourceIdentityPolicy_basic (8.18s)
--- PASS: TestResourceIdentityPolicyTestSuite (8.18s)
=== RUN TestResourceIdentitySwiftPasswordTestSuite
=== RUN TestAccResourceIdentitySwiftPassword_basic
--- PASS: TestAccResourceIdentitySwiftPassword_basic (2.11s)
--- PASS: TestResourceIdentitySwiftPasswordTestSuite (2.11s)
=== RUN TestResourceIdentityUIPasswordTestSuite
=== RUN TestAccIdentityUIPassword_basic
--- PASS: TestAccIdentityUIPassword_basic (1.25s)
--- PASS: TestResourceIdentityUIPasswordTestSuite (1.25s)
=== RUN TestResourceIdentityUserGroupMembershipTestSuite
=== RUN TestAccResourceUserGroupMemberships_basic
--- PASS: TestAccResourceUserGroupMemberships_basic (4.64s)
--- PASS: TestResourceIdentityUserGroupMembershipTestSuite (4.64s)
=== RUN TestResourceIdentityUserTestSuite
=== RUN TestAccResourceIdentityUser_basic
--- PASS: TestAccResourceIdentityUser_basic (1.24s)
--- PASS: TestResourceIdentityUserTestSuite (1.24s)
PASS
ok github.com/oracle/terraform-provider-oci 55.373s