Support empty route rules #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangustafson
approved these changes
Sep 15, 2017
resource_obmcs_core_route_table.go
Outdated
| routeRules = []baremetal.RouteRule{} | ||
| for _, val := range s.D.Get("route_rules").([]interface{}) { | ||
|
|
||
| if val == nil { | ||
| return nil, fmt.Errorf("Empty route_rules are not permitted, omit empty blocks entirely.") |
There was a problem hiding this comment.
How about: "Empty route_rules are not permitted. Instead, the route_rules block may be omitted entirely."
codycushing
force-pushed
the
cush-empty-route-rules
branch
from
d42b18b to
03516dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test output
TF_ORACLE_ENV=test TF_ACC=1 go test -v -timeout 120m -run TestResourceCoreRouteTableTestSuite
=== RUN TestResourceCoreRouteTableTestSuite
=== RUN TestAccResourceCoreRouteTable_basic
--- PASS: TestAccResourceCoreRouteTable_basic (46.57s)
--- PASS: TestResourceCoreRouteTableTestSuite (46.57s)
PASS
ok github.com/oracle/terraform-provider-oci 46.585s