Skip to content

Conversation

@vladak
Copy link
Member

@vladak vladak commented Oct 31, 2022

When running indexer to create annotation cache for some repositories, I noticed these log entries:

2022-10-31 14:46:38.034+0100 SEVERE t1253 MercurialAnnotationParser.processStream: Error: did not find annotation in line 1: [thunderbird-icon.png: binary file]

The log severity is too high. The SEVERE should be reserved for general indexer failures, not used for problems to create particular index data.

Also, luckily, the output in this case contained the filename so one might be able to see what is going on, however sometimes this is not the case. A filename should be added to the log statement.

@vladak vladak added the indexer label Oct 31, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 31, 2022
@vladak vladak merged commit 8a7aa08 into oracle:master Oct 31, 2022
@vladak vladak deleted the annotation_errors branch October 31, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

indexer OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant