-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GR-52129] Augment RuntimeClassInitialization#initializeAtBuildTime javadoc #8230
[GR-52129] Augment RuntimeClassInitialization#initializeAtBuildTime javadoc #8230
Conversation
Thanks for the PR, @zakkak. Aren't you documenting more of a bug or do you actually make use of this? Registering everything for build-time initialization seems rather dangerous. |
This is actually a feature for Quarkus, one that we specifically requested to keep being able to use when the option to use Although build-time initialization can be a double-edged sword Quarkus is still using it by default for all classes due to its benefits despite requiring more work to be done on the framework side. Corresponding Quarkus Issue quarkusio/quarkus#17887 |
Understood. From a pure user's perspective, this is still concerning: what if users calculate the value dynamically and it happens to be |
I don't see another way without making a breaking change. I would not be worried as this is used only by the power users. |
...c/org.graalvm.nativeimage/src/org/graalvm/nativeimage/hosted/RuntimeClassInitialization.java
Outdated
Show resolved
Hide resolved
Document that using `""` as the package name results in all packages and classes being registered for build time initialization.
e201387
to
0ce09da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Document that using
""
as the package name results in all packages andclasses being registered for build time initialization.