Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-52129] Augment RuntimeClassInitialization#initializeAtBuildTime javadoc #8230

Merged

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jan 23, 2024

Document that using "" as the package name results in all packages and
classes being registered for build time initialization.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 23, 2024
@fniephaus
Copy link
Member

Thanks for the PR, @zakkak. Aren't you documenting more of a bug or do you actually make use of this? Registering everything for build-time initialization seems rather dangerous.

@zakkak
Copy link
Collaborator Author

zakkak commented Jan 23, 2024

Thanks for the PR, @zakkak. Aren't you documenting more of a bug or do you actually make use of this? Registering everything for build-time initialization seems rather dangerous.

This is actually a feature for Quarkus, one that we specifically requested to keep being able to use when the option to use --initialize-at-build-time without arguments was deprecated (5013ca7).

Although build-time initialization can be a double-edged sword Quarkus is still using it by default for all classes due to its benefits despite requiring more work to be done on the framework side.

Corresponding Quarkus Issue quarkusio/quarkus#17887

@fniephaus fniephaus self-assigned this Jan 23, 2024
@fniephaus
Copy link
Member

Understood. From a pure user's perspective, this is still concerning: what if users calculate the value dynamically and it happens to be "". Similar to null values, maybe we want to guard from accidental misuse somehow? What do you think, @vjovanov?

@vjovanov
Copy link
Member

I don't see another way without making a breaking change. I would not be worried as this is used only by the power users.

Document that using `""` as the package name results in all packages and
classes being registered for build time initialization.
@zakkak zakkak force-pushed the 2024-01-23-initializeatbuildtime-javadoc branch from e201387 to 0ce09da Compare January 26, 2024 12:26
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fniephaus fniephaus changed the title Augment RuntimeClassInitialization#initializeAtBuildTime javadoc [GR-52129] Augment RuntimeClassInitialization#initializeAtBuildTime javadoc Feb 15, 2024
@graalvmbot graalvmbot merged commit 0ce09da into oracle:master Feb 20, 2024
12 checks passed
@zakkak zakkak deleted the 2024-01-23-initializeatbuildtime-javadoc branch February 21, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants