Adding OpenContainer image-spec labels to OracleLinuxDeveloper images #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs images Signed-off-by: Avi Miller <[email protected]>
mark-au
requested changes
Sep 15, 2020
There was a problem hiding this comment.
Two minor typos. Looks like we could also give a version (https://github.com/opencontainers/image-spec/blob/master/annotations.md#pre-defined-annotation-keys) which could be useful but unsure if we want to include today.
OracleLinuxDevelopers/oraclelinux7/nodejs/10-oracledb/Dockerfile
Outdated
Show resolved
Hide resolved
OracleLinuxDevelopers/oraclelinux7/nodejs/12-oracledb/Dockerfile
Outdated
Show resolved
Hide resolved
Signed-off-by: Avi Miller <[email protected]>
|
Ah, well spotted. Fixed. |
mark-au
approved these changes
Sep 15, 2020
|
On the version, because these images are combinations of a particular Oracle Linux version with a particular language version, I didn't want to confusing things by only specifying one. I do recommend other images use version when the container only contains a single product/package/project, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These labels are used by GitHub Container Registry as well as third-party registry and orchestration tools.
Also fixes a typo bug in
oraclelinux7/python/3.6-oracledb/Dockerfile.Signed-off-by: Avi Miller [email protected]