36 upgrade to 0.12 syntax #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 22, 2021 22:09
Signed-off-by: Alexey Dolganov <[email protected]>
Add Copyright 2021 Signed-off-by: Alexey Dolganov <[email protected]>
Signed-off-by: Alexey Dolganov <[email protected]>
Signed-off-by: Alexey Dolganov <[email protected]>
Signed-off-by: Alexey Dolganov <[email protected]>
kral2
reviewed
Jan 31, 2021
| @@ -1,39 +1,60 @@ | |||
| // Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. | |||
| // Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
"All rights reserved" is not needed anymore. Copyright notice should be as below:
// Copyright (c) 2018, 2021 Oracle and/or its affiliates.
Lets batch copyright notice cleaning with next update.
bump version to 2.0.3 Signed-off-by: Alexey Dolganov <[email protected]>
|
Cleaned up copyright statements, see last commit |
kral2
approved these changes
Feb 3, 2021
| @@ -0,0 +1,4 @@ | |||
|
|
|||
| terraform { | |||
| required_version = ">= 0.12" | |||
There was a problem hiding this comment.
Suggested change
| required_version = ">= 0.12" | |
| required_version = ">= 0.12, < 0.13" |
terraform config should prevent update greater than 0.12 as this module is not tested/known working with versions greater that 0.12
this suggestion do not apply to version constraints inside module: their we want to specify only minimum version.
This was
linked to
issues
Feb 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues #34 and #36
plus minor readme file updates.