Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarterly QA Fixes WMS 11754 - Oracle Integration 3 - Using OIC Native Actions to Harness OCI Services #74

Merged
merged 411 commits into from
Jan 7, 2025

Conversation

kkatta11
Copy link
Contributor

@kkatta11 kkatta11 commented Jan 3, 2025

Add here your WMS ID

11754 - Oracle Integration 3 - Using OIC Native Actions to Harness OCI Services

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

Copy link
Contributor

@dannymgithub dannymgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkatta11 please update your Acknowledgements pages, I've noticed there are November 2024 dates where you made changes.

@kkatta11
Copy link
Contributor Author

kkatta11 commented Jan 7, 2025

@dannymgithub I changed only 2 files create-function.md and introduction.md. Both the files have correct date in acks. Let me know the file name if it is otherwise.

@hope-fisher
Copy link
Member

@dannymgithub I changed only 2 files create-function.md and introduction.md. Both the files have correct date in acks. Let me know the file name if it is otherwise.

Hi @kkatta11, in the Files Changes for this PR, we're seeing that November 2024 acknowledgment in these two files:

  • oic-gen3/core-competencies/rapid-adapter-builder/get-started-rab/setup/setup.md
  • oic-gen3/core-competencies/rapid-adapter-builder/get-started-rab/develop-adapter/develop-adapter.md

@kkatta11
Copy link
Contributor Author

kkatta11 commented Jan 7, 2025

@hope-fisher Yes, those changes were part of my previous PR which was merged long back. Not sure why this is coming up in the current PR

@hope-fisher hope-fisher dismissed dannymgithub’s stale review January 7, 2025 22:36

updated files include most recent date in acknowledgements.

@hope-fisher hope-fisher merged commit 4753c7b into oracle-livelabs:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants