Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support PyTorch-lightning DDP training #2824

Closed
wants to merge 6 commits into from

Conversation

tohmae
Copy link
Contributor

@tohmae tohmae commented Jul 27, 2021

This PR addresses issue #2699.
This is related to Lightning-AI/pytorch-lightning#7916.
So DDP training on multi GPUs supports from pytorch-lightning version 1.4.0.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Jul 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2824 (0a48595) into master (e0fd830) will decrease coverage by 0.31%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2824      +/-   ##
==========================================
- Coverage   91.79%   91.48%   -0.32%     
==========================================
  Files         146      147       +1     
  Lines       11192    11368     +176     
==========================================
+ Hits        10274    10400     +126     
- Misses        918      968      +50     
Impacted Files Coverage Δ
optuna/integration/pytorch_lightning.py 88.23% <87.50%> (-0.66%) ⬇️
optuna/cli.py 26.97% <0.00%> (-2.60%) ⬇️
optuna/study/_optimize.py 97.77% <0.00%> (-0.04%) ⬇️
optuna/storages/__init__.py 100.00% <0.00%> (ø)
optuna/storages/_heartbeat.py 100.00% <0.00%> (ø)
optuna/samplers/_tpe/sampler.py 96.65% <0.00%> (+0.01%) ⬆️
optuna/samplers/_tpe/parzen_estimator.py 98.93% <0.00%> (+0.03%) ⬆️
optuna/storages/_cached_storage.py 98.69% <0.00%> (+1.62%) ⬆️
optuna/visualization/matplotlib/_contour.py 83.21% <0.00%> (+3.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0fd830...0a48595. Read the comment docs.

@tohmae tohmae changed the title [WIP] Support PyTorch-lightning DDP training Support PyTorch-lightning DDP training Aug 1, 2021
@tohmae tohmae changed the title Support PyTorch-lightning DDP training [WIP} Support PyTorch-lightning DDP training Aug 1, 2021
@tohmae tohmae changed the title [WIP} Support PyTorch-lightning DDP training [WIP] Support PyTorch-lightning DDP training Aug 1, 2021
@tohmae
Copy link
Contributor Author

tohmae commented Aug 1, 2021

I am sorry. This PR is wrong so I closed it.

@tohmae tohmae closed this Aug 1, 2021
@tohmae tohmae deleted the pytorch-lightning-multi-gpu branch August 6, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants